Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(155)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2150933004: milo: dedup testdata (Closed)

Created:
4 years, 5 months ago by nodir
Modified:
4 years, 5 months ago
Reviewers:
Ryan Tseng, estaab, hinoka
CC:
chromium-reviews, infra-reviews+luci-go_chromium.org, andrew.wang, todd, tandrii+luci-go_chromium.org, M-A Ruel
Base URL:
https://chromium.googlesource.com/external/github.com/luci/luci-go@master
Target Ref:
refs/heads/master
Project:
luci-go
Visibility:
Public.

Description

milo: dedup testdata testdata is currently duped in frontend dir, and it is easy to forget to update it. Avoid deduping by changing the path where test data is read from. This still makes a lot of assumptions. R=hinoka@chromium.org, estaab@chromium.org BUG= Committed: https://github.com/luci/luci-go/commit/e72ffaabe7032db124ce9e51135744996637cb36

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -6512 lines) Patch
M appengine/cmd/milo/README.md View 1 chunk +0 lines, -1 line 0 comments Download
M appengine/cmd/milo/buildbot/build.go View 1 chunk +4 lines, -1 line 0 comments Download
A + appengine/cmd/milo/buildbot/testdata/CrWinGoma.30608.json View 0 chunks +-1 lines, --1 lines 0 comments Download
D appengine/cmd/milo/buildbot/testdata/buildbot/CrWinGoma.30608.json View 1 chunk +0 lines, -1 line 0 comments Download
D appengine/cmd/milo/buildbot/testdata/buildbot/win_chromium_rel_ng.246309.json View 1 chunk +0 lines, -1 line 0 comments Download
A + appengine/cmd/milo/buildbot/testdata/win_chromium_rel_ng.246309.json View 0 chunks +-1 lines, --1 lines 0 comments Download
M appengine/cmd/milo/buildbucket/builder.go View 1 chunk +4 lines, -1 line 0 comments Download
D appengine/cmd/milo/buildbucket/testdata/buildbucket/master.tryserver.infra/InfraPresubmit.json View 1 chunk +0 lines, -210 lines 0 comments Download
D appengine/cmd/milo/buildbucket/testdata/buildbucket/master.tryserver.infra/InfraPresubmit(Swarming).json View 1 chunk +0 lines, -415 lines 0 comments Download
A + appengine/cmd/milo/buildbucket/testdata/master.tryserver.infra/InfraPresubmit.json View 0 chunks +-1 lines, --1 lines 0 comments Download
A + appengine/cmd/milo/buildbucket/testdata/master.tryserver.infra/InfraPresubmit(Swarming).json View 0 chunks +-1 lines, --1 lines 0 comments Download
D appengine/cmd/milo/frontend/testdata/build-exception View 1 chunk +0 lines, -1 line 0 comments Download
D appengine/cmd/milo/frontend/testdata/build-exception.swarm View 1 chunk +0 lines, -1 line 0 comments Download
D appengine/cmd/milo/frontend/testdata/build-patch-failure View 1 chunk +0 lines, -5875 lines 0 comments Download
D appengine/cmd/milo/frontend/testdata/build-patch-failure.swarm View 1 chunk +0 lines, -1 line 0 comments Download
D appengine/cmd/milo/frontend/testdata/build-pending.swarm View 1 chunk +0 lines, -1 line 0 comments Download
D appengine/cmd/milo/frontend/testdata/build-timeout View 1 chunk +0 lines, -1 line 0 comments Download
D appengine/cmd/milo/frontend/testdata/build-timeout.swarm View 1 chunk +0 lines, -1 line 0 comments Download
D appengine/cmd/milo/frontend/testdata/buildbot/CrWinGoma.30608.json View 1 chunk +0 lines, -1 line 0 comments Download
D appengine/cmd/milo/frontend/testdata/buildbot/win_chromium_rel_ng.246309.json View 1 chunk +0 lines, -1 line 0 comments Download
D appengine/cmd/milo/frontend/testdata/buildbucket View 1 chunk +0 lines, -1 line 0 comments Download
M appengine/cmd/milo/swarming/build.go View 2 chunks +9 lines, -2 lines 0 comments Download

Dependent Patchsets:

Issue 2141013003 Patch 10001
Issue 2141013003 Patch 30001

Messages

Total messages: 9 (4 generated)
nodir
PTAL
4 years, 5 months ago (2016-07-14 23:45:58 UTC) #1
Ryan Tseng
lgtm
4 years, 5 months ago (2016-07-15 16:33:52 UTC) #3
Ryan Tseng
lgtm lgtm
4 years, 5 months ago (2016-07-15 16:33:54 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2150933004/1
4 years, 5 months ago (2016-07-15 16:39:58 UTC) #7
commit-bot: I haz the power
4 years, 5 months ago (2016-07-15 16:48:00 UTC) #9
Message was sent while issue was closed. 
Committed patchset #1 (id:1) as
https://github.com/luci/luci-go/commit/e72ffaabe7032db124ce9e51135744996637cb36

Powered by Google App Engine
This is Rietveld 408576698