Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1877)

Unified Diff: appengine/cmd/milo/buildbucket/builder.go

Issue 2150933004: milo: dedup testdata (Closed) Base URL: https://chromium.googlesource.com/external/github.com/luci/luci-go@master
Patch Set: Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: appengine/cmd/milo/buildbucket/builder.go
diff --git a/appengine/cmd/milo/buildbucket/builder.go b/appengine/cmd/milo/buildbucket/builder.go
index afc53a16f2be882bdf94ee5b841b94003abf87fa..4807f04a0f5a139fb76c14fd31a70bf19d268df3 100644
--- a/appengine/cmd/milo/buildbucket/builder.go
+++ b/appengine/cmd/milo/buildbucket/builder.go
@@ -183,7 +183,10 @@ func toMiloBuild(c context.Context, build *buildbucket.ApiBuildMessage) *resp.Bu
}
func getDebugBuilds(c context.Context, bucket, builder string, maxCompletedBuilds int, target *resp.Builder) error {
- resFile, err := os.Open(filepath.Join("testdata", "buildbucket", bucket, builder+".json"))
+ // ../buildbucket below assumes that
+ // - this code is not executed by tests outside of this dir
+ // - this dir is a sibling of frontend dir
+ resFile, err := os.Open(filepath.Join("..", "buildbucket", "testdata", bucket, builder+".json"))
if err != nil {
return err
}

Powered by Google App Engine
This is Rietveld 408576698