appengine/cmd/milo/buildbot/build.go - Issue 2150933004: milo: dedup testdata

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: appengine/cmd/milo/buildbot/build.go

Issue 2150933004: milo: dedup testdata (Closed) Base URL: https://chromium.googlesource.com/external/github.com/luci/luci-go@master

Patch Set: Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: appengine/cmd/milo/buildbot/build.go

diff --git a/appengine/cmd/milo/buildbot/build.go b/appengine/cmd/milo/buildbot/build.go

index 3def8f059824625d9794a288c3ea7a9c83f1b91a..e27e43dbdc8d4ccc7cb92d32a203065ed5866e96 100644

--- a/appengine/cmd/milo/buildbot/build.go

+++ b/appengine/cmd/milo/buildbot/build.go

@@ -377,7 +377,10 @@ func sourcestamp(c context.Context, b *buildbotBuild) *resp.SourceStamp {

func getDebugBuild(c context.Context, builder, buildNum string) (*buildbotBuild, error) {

fname := fmt.Sprintf("%s.%s.json", builder, buildNum)

- path := filepath.Join("testdata", "buildbot", fname)

+ // ../buildbot below assumes that

+ // - this code is not executed by tests outside of this dir

+ // - this dir is a sibling of frontend dir

+ path := filepath.Join("..", "buildbot", "testdata", fname)

raw, err := ioutil.ReadFile(path)

if err != nil {

return nil, err