Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(122)

Issue 2141013003: milo: fix build/step timing (Closed)

Created:
4 years, 5 months ago by nodir
Modified:
4 years, 5 months ago
Reviewers:
estaab, hinoka
CC:
andrew.wang, chromium-reviews, infra-reviews+luci-go_chromium.org, M-A Ruel, tandrii+luci-go_chromium.org, todd
Base URL:
https://chromium.googlesource.com/external/github.com/luci/luci-go@master
Target Ref:
refs/heads/master
Project:
luci-go
Visibility:
Public.

Description

milo: fix build/step timing This CL fixes two bugs: 1) confused swarming task StartedTs and CompletedTs 2) hang steps in infrafailed builds stayed Running and we compute their duration till now R=hinoka@chromium.org, estaab@chromium.org BUG=626853 Committed: https://github.com/luci/luci-go/commit/2d9c0bca8435d223d907cca702bbeb347a6a83b1

Patch Set 1 #

Patch Set 2 : rebased on top of CL that dedupes testdata #

Patch Set 3 : remove unnecessary symlink #

Patch Set 4 : rebase #

Patch Set 5 : retrain #

Unified diffs Side-by-side diffs Delta from patch set Stats (+156 lines, -45 lines) Patch
M appengine/cmd/milo/logdog/logDogBuild.go View 1 6 chunks +19 lines, -5 lines 0 comments Download
M appengine/cmd/milo/resp/build.go View 1 2 3 1 chunk +10 lines, -0 lines 0 comments Download
A appengine/cmd/milo/settings/funcs_test.go View 1 1 chunk +28 lines, -0 lines 0 comments Download
M appengine/cmd/milo/swarming/build.go View 1 1 chunk +1 line, -1 line 0 comments Download
M appengine/cmd/milo/swarming/build_test.go View 1 1 chunk +1 line, -0 lines 0 comments Download
M appengine/cmd/milo/swarming/expectations/build-canceled.json View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M appengine/cmd/milo/swarming/expectations/build-exception.json View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
A + appengine/cmd/milo/swarming/expectations/build-hang.json View 1 2 3 4 5 chunks +34 lines, -36 lines 0 comments Download
M appengine/cmd/milo/swarming/expectations/build-timeout.json View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
A appengine/cmd/milo/swarming/testdata/build-hang View 1 1 chunk +42 lines, -0 lines 0 comments Download
A appengine/cmd/milo/swarming/testdata/build-hang.swarm View 1 1 chunk +18 lines, -0 lines 0 comments Download

Messages

Total messages: 19 (9 generated)
nodir
PTAL
4 years, 5 months ago (2016-07-12 23:59:55 UTC) #1
nodir
after-conf ping
4 years, 5 months ago (2016-07-14 17:46:49 UTC) #2
nodir
rebased on top of https://codereview.chromium.org/2150933004/
4 years, 5 months ago (2016-07-15 00:15:26 UTC) #4
estaab
lgtm
4 years, 5 months ago (2016-07-15 05:24:46 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2141013003/30001
4 years, 5 months ago (2016-07-16 07:03:08 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: Luci-go Linux Precise 32 Tester on master.tryserver.infra (JOB_FAILED, https://build.chromium.org/p/tryserver.infra/builders/Luci-go%20Linux%20Precise%2032%20Tester/builds/1392) ...
4 years, 5 months ago (2016-07-16 07:04:44 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2141013003/50001
4 years, 5 months ago (2016-07-16 07:10:54 UTC) #12
commit-bot: I haz the power
Try jobs failed on following builders: Luci-go Mac Tester on master.tryserver.infra (JOB_FAILED, https://build.chromium.org/p/tryserver.infra/builders/Luci-go%20Mac%20Tester/builds/1378) Luci-go Mac ...
4 years, 5 months ago (2016-07-16 07:15:04 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2141013003/70001
4 years, 5 months ago (2016-07-18 18:24:07 UTC) #17
commit-bot: I haz the power
4 years, 5 months ago (2016-07-18 18:37:40 UTC) #19
Message was sent while issue was closed.
Committed patchset #5 (id:70001) as
https://github.com/luci/luci-go/commit/2d9c0bca8435d223d907cca702bbeb347a6a83b1

Powered by Google App Engine
This is Rietveld 408576698