[DevTools] Add callFrame to CPUProfileNode & SamplingHeapProfileNode

[DevTools] Add callFrame to CPUProfileNode & SamplingHeapProfileNode

- functionName, scriptId, url, lineNumber, columnNumber -> callFrame (Runtime.CallFrame);
- callFrame.lineNumber & callFrame.columnNumber are 0-based
- fix closure compiler types in CPUProfileDataModel.js

R=dgozman@chromium.org,alph@chromium.org
BUG=591496
Committed: https://crrev.com/4aab40a95c7c9f01d7c258c1095b13f5c75300eb
Cr-Commit-Position: refs/heads/master@{#405670}

[kozy, 2016-07-14 00:18:21]

Description was changed from

==========
[DevTools] Aggregate callsite info in CPUProfileNode & SamplingHeapProfileNode

- functionName, scriptId, url, lineNumber, columnNumber -> callFrame
(Runtime.CallFrame);
- callFrame.lineNumber & callFrame.columnNumber are 0-based
- fix closure compiler types in CPUProfileDataModel.js

R=dgozman@chromium.org,alph@chromium.org
BUG=591496
==========

to

==========
[DevTools] Add callFrame to CPUProfileNode & SamplingHeapProfileNode

- functionName, scriptId, url, lineNumber, columnNumber -> callFrame
(Runtime.CallFrame);
- callFrame.lineNumber & callFrame.columnNumber are 0-based
- fix closure compiler types in CPUProfileDataModel.js

R=dgozman@chromium.org,alph@chromium.org
BUG=591496
==========

[kozy, 2016-07-14 00:21:44]

Alexei and Dmitry, please take a look!

[kozy, 2016-07-14 00:22:30]

Patchset #1 (id:1) has been deleted

[kozy, 2016-07-14 00:22:36]

The CQ bit was checked by kozyatinskiy@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-07-14 00:23:57]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-14 02:50:00]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-14 02:50:01]

Dry run: This issue passed the CQ dry run.

[dgozman, 2016-07-14 15:58:28]

looks good, deferring to alph@

https://codereview.chromium.org/2150803002/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/devtools/front_end/sdk/ProfileTreeModel.js
(right):

https://codereview.chromium.org/2150803002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/sdk/ProfileTreeModel.js:16:
lineNumber: callFrame.lineNumber + 1,
Are you going to migrate frontend code in the next patch?

[alph, 2016-07-14 17:56:00]

https://codereview.chromium.org/2150803002/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/devtools/front_end/profiler/HeapProfileView.js
(right):

https://codereview.chromium.org/2150803002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/profiler/HeapProfileView.js:224:
WebInspector.ProfileNode.call(this, node.callFrame);
I guess we need to retain backward compatibility in this place.

https://codereview.chromium.org/2150803002/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/devtools/front_end/sdk/CPUProfileDataModel.js
(right):

https://codereview.chromium.org/2150803002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/sdk/CPUProfileDataModel.js:13:
WebInspector.ProfileNode.call(this, sourceNode.callFrame);
ditto

https://codereview.chromium.org/2150803002/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/devtools/front_end/sdk/ProfileTreeModel.js
(right):

https://codereview.chromium.org/2150803002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/sdk/ProfileTreeModel.js:12:
this.frame = {
The plan was to have this.frame = callFrame;

[kozy, 2016-07-14 21:34:53]

The CQ bit was checked by kozyatinskiy@chromium.org to run a CQ dry run

[kozy, 2016-07-14 21:35:04]

All done. Please take a look!

https://codereview.chromium.org/2150803002/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/devtools/front_end/profiler/HeapProfileView.js
(right):

https://codereview.chromium.org/2150803002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/profiler/HeapProfileView.js:224:
WebInspector.ProfileNode.call(this, node.callFrame);
On 2016/07/14 17:56:00, alph wrote:
> I guess we need to retain backward compatibility in this place.

Done.

https://codereview.chromium.org/2150803002/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/devtools/front_end/sdk/CPUProfileDataModel.js
(right):

https://codereview.chromium.org/2150803002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/sdk/CPUProfileDataModel.js:13:
WebInspector.ProfileNode.call(this, sourceNode.callFrame);
On 2016/07/14 17:56:00, alph wrote:
> ditto

Done.

https://codereview.chromium.org/2150803002/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/devtools/front_end/sdk/ProfileTreeModel.js
(right):

https://codereview.chromium.org/2150803002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/sdk/ProfileTreeModel.js:12:
this.frame = {
On 2016/07/14 17:56:00, alph wrote:
> The plan was to have this.frame = callFrame;

Done.

https://codereview.chromium.org/2150803002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/sdk/ProfileTreeModel.js:16:
lineNumber: callFrame.lineNumber + 1,
On 2016/07/14 15:58:28, dgozman wrote:
> Are you going to migrate frontend code in the next patch?

It was first plan, added migration right here.

[commit-bot: I haz the power, 2016-07-14 21:35:52]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[alph, 2016-07-14 21:53:29]

lgtm

https://codereview.chromium.org/2150803002/diff/40001/third_party/WebKit/Sour...
File third_party/WebKit/Source/devtools/front_end/profiler/HeapProfileView.js
(right):

https://codereview.chromium.org/2150803002/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/profiler/HeapProfileView.js:229:
WebInspector.ProfileNode.call(this, { functionName: frame.functionName,
scriptId: frame.scriptId, url: frame.url, lineNumber: frame.lineNumber - 1,
columnNumber: frame.columnNumber - 1});
could you please format it to have a field per line.

https://codereview.chromium.org/2150803002/diff/40001/third_party/WebKit/Sour...
File third_party/WebKit/Source/devtools/front_end/sdk/CPUProfileDataModel.js
(right):

https://codereview.chromium.org/2150803002/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/sdk/CPUProfileDataModel.js:18:
WebInspector.ProfileNode.call(this, { functionName: frame.functionName,
scriptId: frame.scriptId, url: frame.url, lineNumber: frame.lineNumber - 1,
columnNumber: frame.columnNumber - 1});
ditto

https://codereview.chromium.org/2150803002/diff/40001/third_party/WebKit/Sour...
File third_party/WebKit/Source/platform/v8_inspector/js_protocol.json (right):

https://codereview.chromium.org/2150803002/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/platform/v8_inspector/js_protocol.json:786: { "name":
"callFrame", "$ref": "Runtime.CallFrame", "description": "Callsite information."
},
Technically it's not about a call site as we do not distinguish two call sites
in a function.

[commit-bot: I haz the power, 2016-07-14 23:03:50]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-14 23:03:51]

Dry run: Try jobs failed on following builders:
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[kozy, 2016-07-15 00:19:02]

All done!

Dmitry, please take a look on protocol.json.

https://codereview.chromium.org/2150803002/diff/40001/third_party/WebKit/Sour...
File third_party/WebKit/Source/devtools/front_end/profiler/HeapProfileView.js
(right):

https://codereview.chromium.org/2150803002/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/profiler/HeapProfileView.js:229:
WebInspector.ProfileNode.call(this, { functionName: frame.functionName,
scriptId: frame.scriptId, url: frame.url, lineNumber: frame.lineNumber - 1,
columnNumber: frame.columnNumber - 1});
On 2016/07/14 21:53:28, alph wrote:
> could you please format it to have a field per line.

Done.

https://codereview.chromium.org/2150803002/diff/40001/third_party/WebKit/Sour...
File third_party/WebKit/Source/devtools/front_end/sdk/CPUProfileDataModel.js
(right):

https://codereview.chromium.org/2150803002/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/sdk/CPUProfileDataModel.js:18:
WebInspector.ProfileNode.call(this, { functionName: frame.functionName,
scriptId: frame.scriptId, url: frame.url, lineNumber: frame.lineNumber - 1,
columnNumber: frame.columnNumber - 1});
On 2016/07/14 21:53:29, alph wrote:
> ditto

Done.

https://codereview.chromium.org/2150803002/diff/40001/third_party/WebKit/Sour...
File third_party/WebKit/Source/platform/v8_inspector/js_protocol.json (right):

https://codereview.chromium.org/2150803002/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/platform/v8_inspector/js_protocol.json:786: { "name":
"callFrame", "$ref": "Runtime.CallFrame", "description": "Callsite information."
},
On 2016/07/14 21:53:29, alph wrote:
> Technically it's not about a call site as we do not distinguish two call sites
> in a function.

Changed to Function location.

[kozy, 2016-07-15 00:19:08]

The CQ bit was checked by kozyatinskiy@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-07-15 00:19:25]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[dgozman, 2016-07-15 00:23:47]

protocol lgtm

[kozy, 2016-07-15 00:32:20]

The CQ bit was unchecked by kozyatinskiy@chromium.org

[kozy, 2016-07-15 00:32:26]

The CQ bit was checked by kozyatinskiy@chromium.org

[kozy, 2016-07-15 00:32:26]

The patchset sent to the CQ was uploaded after l-g-t-m from alph@chromium.org
Link to the patchset: https://codereview.chromium.org/2150803002/#ps60001
(title: "addressed comments")

[commit-bot: I haz the power, 2016-07-15 00:32:50]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-15 01:37:30]

Description was changed from

==========
[DevTools] Add callFrame to CPUProfileNode & SamplingHeapProfileNode

- functionName, scriptId, url, lineNumber, columnNumber -> callFrame
(Runtime.CallFrame);
- callFrame.lineNumber & callFrame.columnNumber are 0-based
- fix closure compiler types in CPUProfileDataModel.js

R=dgozman@chromium.org,alph@chromium.org
BUG=591496
==========

to

==========
[DevTools] Add callFrame to CPUProfileNode & SamplingHeapProfileNode

- functionName, scriptId, url, lineNumber, columnNumber -> callFrame
(Runtime.CallFrame);
- callFrame.lineNumber & callFrame.columnNumber are 0-based
- fix closure compiler types in CPUProfileDataModel.js

R=dgozman@chromium.org,alph@chromium.org
BUG=591496
==========

[commit-bot: I haz the power, 2016-07-15 01:37:32]

Committed patchset #3 (id:60001)

[commit-bot: I haz the power, 2016-07-15 01:37:44]

CQ bit was unchecked.

[commit-bot: I haz the power, 2016-07-15 01:38:50]

Description was changed from

==========
[DevTools] Add callFrame to CPUProfileNode & SamplingHeapProfileNode

- functionName, scriptId, url, lineNumber, columnNumber -> callFrame
(Runtime.CallFrame);
- callFrame.lineNumber & callFrame.columnNumber are 0-based
- fix closure compiler types in CPUProfileDataModel.js

R=dgozman@chromium.org,alph@chromium.org
BUG=591496
==========

to

==========
[DevTools] Add callFrame to CPUProfileNode & SamplingHeapProfileNode

- functionName, scriptId, url, lineNumber, columnNumber -> callFrame
(Runtime.CallFrame);
- callFrame.lineNumber & callFrame.columnNumber are 0-based
- fix closure compiler types in CPUProfileDataModel.js

R=dgozman@chromium.org,alph@chromium.org
BUG=591496

Committed: https://crrev.com/4aab40a95c7c9f01d7c258c1095b13f5c75300eb
Cr-Commit-Position: refs/heads/master@{#405670}
==========

[commit-bot: I haz the power, 2016-07-15 01:38:51]

Patchset 3 (id:??) landed as
https://crrev.com/4aab40a95c7c9f01d7c258c1095b13f5c75300eb
Cr-Commit-Position: refs/heads/master@{#405670}