Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(486)

Unified Diff: third_party/WebKit/Source/devtools/front_end/sdk/ProfileTreeModel.js

Issue 2150803002: [DevTools] Add callFrame to CPUProfileNode & SamplingHeapProfileNode (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: addressed comments Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/devtools/front_end/sdk/ProfileTreeModel.js
diff --git a/third_party/WebKit/Source/devtools/front_end/sdk/ProfileTreeModel.js b/third_party/WebKit/Source/devtools/front_end/sdk/ProfileTreeModel.js
index ca885ed9d775c53cf74b315f4e7dd9310e92802f..5ceb738dea1fd3d800b7b1685e409932dc1989c8 100644
--- a/third_party/WebKit/Source/devtools/front_end/sdk/ProfileTreeModel.js
+++ b/third_party/WebKit/Source/devtools/front_end/sdk/ProfileTreeModel.js
@@ -4,19 +4,14 @@
/**
* @constructor
+ * @param {!RuntimeAgent.CallFrame} callFrame
*/
-WebInspector.ProfileNode = function(functionName, scriptId, url, lineNumber, columnNumber)
+WebInspector.ProfileNode = function(callFrame)
{
/** @type {!RuntimeAgent.CallFrame} */
- this.frame = {
- functionName: functionName,
- scriptId: scriptId,
- url: url,
- lineNumber: lineNumber,
- columnNumber: columnNumber
- };
+ this.callFrame = callFrame;
/** @type {string} */
- this.callUID = `${this.frame.functionName}@${this.frame.scriptId}:${this.frame.lineNumber}`;
+ this.callUID = `${this.callFrame.functionName}@${this.callFrame.scriptId}:${this.callFrame.lineNumber}`;
/** @type {number} */
this.self = 0;
/** @type {number} */
@@ -35,7 +30,7 @@ WebInspector.ProfileNode.prototype = {
*/
get functionName()
{
- return this.frame.functionName;
+ return this.callFrame.functionName;
},
/**
@@ -43,7 +38,7 @@ WebInspector.ProfileNode.prototype = {
*/
get scriptId()
{
- return this.frame.scriptId;
+ return this.callFrame.scriptId;
},
/**
@@ -51,7 +46,7 @@ WebInspector.ProfileNode.prototype = {
*/
get url()
{
- return this.frame.url;
+ return this.callFrame.url;
},
/**
@@ -59,7 +54,7 @@ WebInspector.ProfileNode.prototype = {
*/
get lineNumber()
{
- return this.frame.lineNumber;
+ return this.callFrame.lineNumber;
},
/**
@@ -67,7 +62,7 @@ WebInspector.ProfileNode.prototype = {
*/
get columnNumber()
{
- return this.frame.columnNumber;
+ return this.callFrame.columnNumber;
}
}

Powered by Google App Engine
This is Rietveld 408576698