Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(68)

Side by Side Diff: third_party/WebKit/Source/platform/v8_inspector/V8ProfilerAgentImpl.cpp

Issue 2150803002: [DevTools] Add callFrame to CPUProfileNode & SamplingHeapProfileNode (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: addressed comments Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2015 The Chromium Authors. All rights reserved. 1 // Copyright 2015 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "platform/v8_inspector/V8ProfilerAgentImpl.h" 5 #include "platform/v8_inspector/V8ProfilerAgentImpl.h"
6 6
7 #include "platform/v8_inspector/Atomics.h" 7 #include "platform/v8_inspector/Atomics.h"
8 #include "platform/v8_inspector/V8DebuggerImpl.h" 8 #include "platform/v8_inspector/V8DebuggerImpl.h"
9 #include "platform/v8_inspector/V8InspectorSessionImpl.h" 9 #include "platform/v8_inspector/V8InspectorSessionImpl.h"
10 #include "platform/v8_inspector/V8StackTraceImpl.h" 10 #include "platform/v8_inspector/V8StackTraceImpl.h"
(...skipping 38 matching lines...) Expand 10 before | Expand all | Expand 10 after
49 49
50 std::unique_ptr<protocol::Array<protocol::Profiler::CPUProfileNode>> childre n = protocol::Array<protocol::Profiler::CPUProfileNode>::create(); 50 std::unique_ptr<protocol::Array<protocol::Profiler::CPUProfileNode>> childre n = protocol::Array<protocol::Profiler::CPUProfileNode>::create();
51 const int childrenCount = node->GetChildrenCount(); 51 const int childrenCount = node->GetChildrenCount();
52 for (int i = 0; i < childrenCount; i++) { 52 for (int i = 0; i < childrenCount; i++) {
53 const v8::CpuProfileNode* child = node->GetChild(i); 53 const v8::CpuProfileNode* child = node->GetChild(i);
54 children->addItem(buildInspectorObjectFor(isolate, child)); 54 children->addItem(buildInspectorObjectFor(isolate, child));
55 } 55 }
56 56
57 std::unique_ptr<protocol::Array<protocol::Profiler::PositionTickInfo>> posit ionTicks = buildInspectorObjectForPositionTicks(node); 57 std::unique_ptr<protocol::Array<protocol::Profiler::PositionTickInfo>> posit ionTicks = buildInspectorObjectForPositionTicks(node);
58 58
59 std::unique_ptr<protocol::Profiler::CPUProfileNode> result = protocol::Profi ler::CPUProfileNode::create() 59 std::unique_ptr<protocol::Runtime::CallFrame> callFrame = protocol::Runtime: :CallFrame::create()
60 .setFunctionName(toProtocolString(node->GetFunctionName())) 60 .setFunctionName(toProtocolString(node->GetFunctionName()))
61 .setScriptId(String16::fromInteger(node->GetScriptId())) 61 .setScriptId(String16::fromInteger(node->GetScriptId()))
62 .setUrl(toProtocolString(node->GetScriptResourceName())) 62 .setUrl(toProtocolString(node->GetScriptResourceName()))
63 .setLineNumber(node->GetLineNumber()) 63 .setLineNumber(node->GetLineNumber() - 1)
64 .setColumnNumber(node->GetColumnNumber()) 64 .setColumnNumber(node->GetColumnNumber() - 1)
65 .build();
66 std::unique_ptr<protocol::Profiler::CPUProfileNode> result = protocol::Profi ler::CPUProfileNode::create()
67 .setCallFrame(std::move(callFrame))
65 .setHitCount(node->GetHitCount()) 68 .setHitCount(node->GetHitCount())
66 .setChildren(std::move(children)) 69 .setChildren(std::move(children))
67 .setPositionTicks(std::move(positionTicks)) 70 .setPositionTicks(std::move(positionTicks))
68 .setDeoptReason(node->GetBailoutReason()) 71 .setDeoptReason(node->GetBailoutReason())
69 .setId(node->GetNodeId()).build(); 72 .setId(node->GetNodeId()).build();
70 return result; 73 return result;
71 } 74 }
72 75
73 std::unique_ptr<protocol::Array<int>> buildInspectorObjectForSamples(v8::CpuProf ile* v8profile) 76 std::unique_ptr<protocol::Array<int>> buildInspectorObjectForSamples(v8::CpuProf ile* v8profile)
74 { 77 {
(...skipping 206 matching lines...) Expand 10 before | Expand all | Expand 10 after
281 profile->Delete(); 284 profile->Delete();
282 return result; 285 return result;
283 } 286 }
284 287
285 bool V8ProfilerAgentImpl::isRecording() const 288 bool V8ProfilerAgentImpl::isRecording() const
286 { 289 {
287 return m_recordingCPUProfile || !m_startedProfiles.empty(); 290 return m_recordingCPUProfile || !m_startedProfiles.empty();
288 } 291 }
289 292
290 } // namespace blink 293 } // namespace blink
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698