third_party/WebKit/LayoutTests/inspector-protocol/heap-profiler/sampling-heap-profiler.html - Issue 2150803002: [DevTools] Add callFrame to CPUProfileNode & SamplingHeapProfileNode

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/LayoutTests/inspector-protocol/heap-profiler/sampling-heap-profiler.html

Issue 2150803002: [DevTools] Add callFrame to CPUProfileNode & SamplingHeapProfileNode (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: addressed comments Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/LayoutTests/inspector-protocol/cpu-profiler/console-profile.html ('k') | third_party/WebKit/LayoutTests/inspector-protocol/heap-profiler/sampling-heap-profiler-expected.txt » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/LayoutTests/inspector-protocol/heap-profiler/sampling-heap-profiler.html

diff --git a/third_party/WebKit/LayoutTests/inspector-protocol/heap-profiler/sampling-heap-profiler.html b/third_party/WebKit/LayoutTests/inspector-protocol/heap-profiler/sampling-heap-profiler.html

index 5ebc58f19652af03a03c9cab6b28166ddc836487..1b5bf0cfb0aa9acb57cb8ae56d703c3f316b311c 100644

--- a/third_party/WebKit/LayoutTests/inspector-protocol/heap-profiler/sampling-heap-profiler.html

+++ b/third_party/WebKit/LayoutTests/inspector-protocol/heap-profiler/sampling-heap-profiler.html

@@ -58,7 +58,7 @@ function test()

function findNode(root, name, depth)

{

- if (depth < 1 && root.functionName === name)

+ if (depth < 1 && root.callFrame.functionName === name)

return root;

return root.children.reduce((found, child) => found || findNode(child, name, depth - 1), null);

}

@@ -66,7 +66,7 @@ function test()

function logNode(node)

{

var size = typeof node.selfSize === "number" ? node.selfSize ? ">0" : "=0" : "-";

- InspectorTest.log(`size${size} ${node.functionName}:${node.lineNumber}:${node.columnNumber}`);

+ InspectorTest.log(`size${size} ${node.callFrame.functionName}:${node.callFrame.lineNumber}:${node.callFrame.columnNumber}`);

}

//# sourceURL=sampling-heap-profiler.html