Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(42)

Issue 2148793003: Stop testing texture-backed bitmaps in drawbitmaprect GM (Closed)

Created:
4 years, 5 months ago by bsalomon
Modified:
4 years, 5 months ago
Reviewers:
robertphillips, reed1
CC:
reviews_skia.org
Base URL:
https://chromium.googlesource.com/skia.git@hidegrwrap
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Stop testing texture-backed bitmaps in drawbitmaprect GM BUG=skia:5531 GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2148793003 Committed: https://skia.googlesource.com/skia/+/7cf36ccb441956e9e35bc4c9b08bdf8bafd9d4bb

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -12 lines) Patch
M gm/drawbitmaprect.cpp View 4 chunks +3 lines, -12 lines 1 comment Download

Depends on Patchset:

Messages

Total messages: 9 (4 generated)
bsalomon
https://codereview.chromium.org/2148793003/diff/1/gm/drawbitmaprect.cpp File gm/drawbitmaprect.cpp (left): https://codereview.chromium.org/2148793003/diff/1/gm/drawbitmaprect.cpp#oldcode155 gm/drawbitmaprect.cpp:155: canvas->drawBitmapRect(fLargeBitmap, SkRect::MakeIWH(gSize, gSize), &paint); The GM was (arbitrarily) always ...
4 years, 5 months ago (2016-07-13 21:13:08 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2148793003/1
4 years, 5 months ago (2016-07-14 00:21:19 UTC) #5
bsalomon
ping
4 years, 5 months ago (2016-07-14 16:06:00 UTC) #6
reed1
must -- kill -- asLegacyBitmap -- soon lgtm
4 years, 5 months ago (2016-07-14 16:32:18 UTC) #7
commit-bot: I haz the power
4 years, 5 months ago (2016-07-14 16:33:45 UTC) #9
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/7cf36ccb441956e9e35bc4c9b08bdf8bafd9d4bb

Powered by Google App Engine
This is Rietveld 408576698