Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(141)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2147053002: Remove GrWrapTextureInBitmap from public API (Closed)

Created:
4 years, 5 months ago by bsalomon
Modified:
4 years, 5 months ago
Reviewers:
robertphillips, reed1
CC:
reviews_skia.org
Base URL:
https://chromium.googlesource.com/skia.git@wrap
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : rebase #

Total comments: 2

Patch Set 3 : rm SK_API #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -7 lines) Patch
M gm/drawbitmaprect.cpp View 1 chunk +1 line, -1 line 0 comments Download
M include/gpu/SkGr.h View 1 chunk +0 lines, -4 lines 0 comments Download
M src/core/SkCanvas.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
M src/gpu/SkGrPriv.h View 1 2 1 chunk +7 lines, -0 lines 0 comments Download
M tests/BitmapCopyTest.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M tests/GrTextureMipMapInvalidationTest.cpp View 1 chunk +1 line, -1 line 0 comments Download
M tests/ReadPixelsTest.cpp View 1 chunk +1 line, -0 lines 0 comments Download

Depends on Patchset:

Issue 2141973004 Patch 1

Dependent Patchsets:

Issue 2148793003 Patch 1

Messages

Total messages: 12 (6 generated)
bsalomon
4 years, 5 months ago (2016-07-13 20:35:45 UTC) #3
robertphillips
lgtm https://codereview.chromium.org/2147053002/diff/20001/src/gpu/SkGrPriv.h File src/gpu/SkGrPriv.h (right): https://codereview.chromium.org/2147053002/diff/20001/src/gpu/SkGrPriv.h#newcode103 src/gpu/SkGrPriv.h:103: // Using the dreaded SkGrPixelRef ... Do we ...
4 years, 5 months ago (2016-07-13 20:42:13 UTC) #5
reed1
lgtm
4 years, 5 months ago (2016-07-13 20:44:31 UTC) #6
bsalomon
https://codereview.chromium.org/2147053002/diff/20001/src/gpu/SkGrPriv.h File src/gpu/SkGrPriv.h (right): https://codereview.chromium.org/2147053002/diff/20001/src/gpu/SkGrPriv.h#newcode103 src/gpu/SkGrPriv.h:103: // Using the dreaded SkGrPixelRef ... On 2016/07/13 20:42:13, ...
4 years, 5 months ago (2016-07-13 21:07:55 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2147053002/40001
4 years, 5 months ago (2016-07-13 22:20:34 UTC) #10
commit-bot: I haz the power
4 years, 5 months ago (2016-07-13 22:42:43 UTC) #12
Message was sent while issue was closed. 
Committed patchset #3 (id:40001) as
https://skia.googlesource.com/skia/+/614d8f9a3c44e22d77fa909e82119e8a6746e1b1

Powered by Google App Engine
This is Rietveld 408576698