gpu/command_buffer/service/context_state.cc - Issue 2148723004: WebGL 2: make sure VertexAttrib type match the corresponding attrib type in shader

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: gpu/command_buffer/service/context_state.cc

Issue 2148723004: WebGL 2: make sure VertexAttrib type match the corresponding attrib type in shader (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: code clean Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« gpu/command_buffer/service/context_state.h ('K') | « gpu/command_buffer/service/context_state.h ('k') | gpu/command_buffer/service/feature_info.h » ('j') | gpu/command_buffer/service/feature_info.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: gpu/command_buffer/service/context_state.cc

diff --git a/gpu/command_buffer/service/context_state.cc b/gpu/command_buffer/service/context_state.cc

index c19ffa5272b5746ecf65646b057a25364cd65693..e1dc82f1d623a424471f1ad5892d3767619b2721 100644

--- a/gpu/command_buffer/service/context_state.cc

+++ b/gpu/command_buffer/service/context_state.cc

@@ -224,6 +224,10 @@ ContextState::ContextState(FeatureInfo* feature_info,

framebuffer_srgb_(false),

feature_info_(feature_info),

error_state_(ErrorState::Create(error_state_client, logger)) {

+ max_vertex_attribs_ = 0;

Zhenyao Mo 2016/07/22 14:36:47 This should go to the initialization list above.

+ generic_attrib_base_type_mask_.resize(1);

Zhenyao Mo 2016/07/22 14:36:47 No need for this.

+ generic_attrib_base_type_mask_[0] = 0xFFFFFFFF;

Initialize();

}