Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(141)

Unified Diff: gpu/command_buffer/service/feature_info.cc

Issue 2148723004: WebGL 2: make sure VertexAttrib type match the corresponding attrib type in shader (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: code clean Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: gpu/command_buffer/service/feature_info.cc
diff --git a/gpu/command_buffer/service/feature_info.cc b/gpu/command_buffer/service/feature_info.cc
index 46cd137b005cf5f5e9852e66ea28fadca83bd511..973b041a7a7024bee6e3e89dec51712bb36c8493 100644
--- a/gpu/command_buffer/service/feature_info.cc
+++ b/gpu/command_buffer/service/feature_info.cc
@@ -1424,6 +1424,21 @@ bool FeatureInfo::IsWebGLContext() const {
return false;
}
+bool FeatureInfo::IsWebGL2OrES3Context() const {
+ // Switch statement to cause a compile-time error if we miss a case.
Zhenyao Mo 2016/07/22 14:36:47 Since you add a default, this comment is incorrect
+ switch (context_type_) {
+ case CONTEXT_TYPE_WEBGL2:
+ case CONTEXT_TYPE_OPENGLES3:
+ return true;
+ case CONTEXT_TYPE_WEBGL1:
+ case CONTEXT_TYPE_OPENGLES2:
+ return false;
+ default:
+ NOTREACHED();
+ return false;
+ }
+}
+
void FeatureInfo::AddExtensionString(const char* s) {
std::string str(s);
size_t pos = extensions_.find(str);

Powered by Google App Engine
This is Rietveld 408576698