Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(266)

Issue 2147683003: Remove unused arguments in HTMLSelectElement class. (Closed)

Created:
4 years, 5 months ago by tkent
Modified:
4 years, 5 months ago
Reviewers:
keishi
CC:
blink-reviews, blink-reviews-html_chromium.org, chromium-reviews, dglazkov+blink, kinuko+watch
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove unused arguments in HTMLSelectElement class. - Remove |allowMultipleSelection| arguemnt of optionSelectedByUser(). It's always false. - Remove |shift| argument of listBoxSelectItem(). It's always false. Also, make optionSelectedByUser() private. This CL has no behaivor changes. Committed: https://crrev.com/08440aab1b983eba25cf27cce89e34ad49719bb4 Cr-Commit-Position: refs/heads/master@{#405107}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -10 lines) Patch
M third_party/WebKit/Source/core/html/HTMLSelectElement.h View 4 chunks +4 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/core/html/HTMLSelectElement.cpp View 2 chunks +5 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/web/ExternalPopupMenu.cpp View 1 chunk +1 line, -1 line 0 comments Download

Dependent Patchsets:

Messages

Total messages: 8 (3 generated)
tkent
Keishi, would you review this please? It's very trivial.
4 years, 5 months ago (2016-07-13 07:44:38 UTC) #2
keishi
LGTM
4 years, 5 months ago (2016-07-13 09:30:19 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2147683003/1
4 years, 5 months ago (2016-07-13 09:35:39 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-07-13 09:39:38 UTC) #6
commit-bot: I haz the power
4 years, 5 months ago (2016-07-13 09:41:16 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/08440aab1b983eba25cf27cce89e34ad49719bb4
Cr-Commit-Position: refs/heads/master@{#405107}

Powered by Google App Engine
This is Rietveld 408576698