Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(346)

Unified Diff: third_party/WebKit/Source/core/html/HTMLSelectElement.cpp

Issue 2147683003: Remove unused arguments in HTMLSelectElement class. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/html/HTMLSelectElement.cpp
diff --git a/third_party/WebKit/Source/core/html/HTMLSelectElement.cpp b/third_party/WebKit/Source/core/html/HTMLSelectElement.cpp
index 02edf50665c99a319e1d499fedc06f2f48106d6e..c39608b845960f171043cbd4dbd028054d7e37a1 100644
--- a/third_party/WebKit/Source/core/html/HTMLSelectElement.cpp
+++ b/third_party/WebKit/Source/core/html/HTMLSelectElement.cpp
@@ -123,13 +123,13 @@ const AtomicString& HTMLSelectElement::formControlType() const
return m_multiple ? selectMultiple : selectOne;
}
-void HTMLSelectElement::optionSelectedByUser(int optionIndex, bool fireOnChangeNow, bool allowMultipleSelection)
+void HTMLSelectElement::optionSelectedByUser(int optionIndex, bool fireOnChangeNow)
{
// User interaction such as mousedown events can cause list box select
// elements to send change events. This produces that same behavior for
// changes triggered by other code running on behalf of the user.
if (!usesMenuList()) {
- updateSelectedState(item(optionIndex), allowMultipleSelection, false);
+ updateSelectedState(item(optionIndex), false, false);
setNeedsValidityCheck();
if (fireOnChangeNow)
listBoxOnChange();
@@ -208,14 +208,14 @@ String HTMLSelectElement::defaultToolTip() const
return validationMessage();
}
-void HTMLSelectElement::listBoxSelectItem(int listIndex, bool allowMultiplySelections, bool shift, bool fireOnChangeNow)
+void HTMLSelectElement::listBoxSelectItem(int listIndex, bool allowMultiplySelections, bool fireOnChangeNow)
{
if (!multiple()) {
- optionSelectedByUser(listToOptionIndex(listIndex), fireOnChangeNow, false);
+ optionSelectedByUser(listToOptionIndex(listIndex), fireOnChangeNow);
} else {
HTMLElement* element = listItems()[listIndex];
if (isHTMLOptionElement(element))
- updateSelectedState(toHTMLOptionElement(element), allowMultiplySelections, shift);
+ updateSelectedState(toHTMLOptionElement(element), allowMultiplySelections, false);
setNeedsValidityCheck();
if (fireOnChangeNow)
listBoxOnChange();
« no previous file with comments | « third_party/WebKit/Source/core/html/HTMLSelectElement.h ('k') | third_party/WebKit/Source/web/ExternalPopupMenu.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698