Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(424)

Unified Diff: third_party/WebKit/Source/core/html/HTMLSelectElement.h

Issue 2147683003: Remove unused arguments in HTMLSelectElement class. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | third_party/WebKit/Source/core/html/HTMLSelectElement.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/core/html/HTMLSelectElement.h
diff --git a/third_party/WebKit/Source/core/html/HTMLSelectElement.h b/third_party/WebKit/Source/core/html/HTMLSelectElement.h
index 37055b454d6717937550cdea26ec5860b2d3b4e0..ae02da44d2e4bd15cd3d5af4f484dbf1b7055fbd 100644
--- a/third_party/WebKit/Source/core/html/HTMLSelectElement.h
+++ b/third_party/WebKit/Source/core/html/HTMLSelectElement.h
@@ -56,8 +56,6 @@ public:
int selectedIndex() const;
void setSelectedIndex(int);
- void optionSelectedByUser(int index, bool dispatchChangeEvent, bool allowMultipleSelection = false);
-
// For ValidityState
String validationMessage() const override;
bool valueMissing() const override;
@@ -114,8 +112,6 @@ public:
void scrollToSelection();
void scrollToOption(HTMLOptionElement*);
- void listBoxSelectItem(int listIndex, bool allowMultiplySelections, bool shift, bool fireOnChangeNow = true);
-
bool canSelectAll() const;
void selectAll();
int listToOptionIndex(int listIndex) const;
@@ -154,6 +150,9 @@ public:
// Text starting offset in RTL.
LayoutUnit clientPaddingRight() const;
void valueChanged(unsigned listIndex);
+ // TODO(tkent): Rename this. This is used only for multiple-selection
+ // menulist.
+ void listBoxSelectItem(int listIndex, bool allowMultiplySelections, bool fireOnChangeNow);
// A popup is canceled when the popup was hidden without selecting an item.
void popupDidCancel();
// Provisional selection is a selection made using arrow keys or type ahead.
@@ -222,6 +221,7 @@ private:
bool hasPlaceholderLabelOption() const;
+ void optionSelectedByUser(int optionIndex, bool dispatchChangeEvent);
enum SelectOptionFlag {
DeselectOtherOptions = 1 << 0,
DispatchInputAndChangeEvent = 1 << 1,
« no previous file with comments | « no previous file | third_party/WebKit/Source/core/html/HTMLSelectElement.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698