Simplify protocol between SELECT elements and popups.

Simplify protocol between SELECT elements and popups.

- Rename listBoxSelectItem to selectMultipleOptionsByPopup, and it accepts index
  vector.
- Rename valueChanged to selectOptionByPopup.

Single-selection menulist accepts only selectOptionByPopup().
Multiple-selection menulist accepts selectOptionByPopup(-1) and
selectMultipleOptionsByPopup().

Committed: https://crrev.com/bd9726939278a4ce06a29875a89b5dba9f01d2ca
Cr-Commit-Position: refs/heads/master@{#405134}

[tkent, 2016-07-13 08:59:05]

Description was changed from

==========
Simplify protocol between SELECT elements and popups.

- Rename listBoxSelectItem to selectMultipleOptionsByPopup, and it accepts index
  vector.
- Rename valueChanged to selectOptionByPopup.

Single-selection menulist accepts only selectOptionByPopup().
Multiple-selection menulist accepts selectOptionByPopup(-1) and
selectMultipleOptionsByPopup().

BUG=
==========

to

==========
Simplify protocol between SELECT elements and popups.

- Rename listBoxSelectItem to selectMultipleOptionsByPopup, and it accepts index
  vector.
- Rename valueChanged to selectOptionByPopup.

Single-selection menulist accepts only selectOptionByPopup().
Multiple-selection menulist accepts selectOptionByPopup(-1) and
selectMultipleOptionsByPopup().
==========

[tkent, 2016-07-13 08:59:22]

tkent@chromium.org changed reviewers:
+ keishi@chromium.org

[tkent, 2016-07-13 08:59:23]

Keishi, would you review this please?

[keishi, 2016-07-13 09:31:58]

LGTM!

[tkent, 2016-07-13 10:12:33]

The CQ bit was checked by tkent@chromium.org

[commit-bot: I haz the power, 2016-07-13 10:12:45]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-13 11:28:42]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-13 11:28:43]

Try jobs failed on following builders:
  win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)

[tkent, 2016-07-13 12:30:16]

The CQ bit was checked by tkent@chromium.org

[commit-bot: I haz the power, 2016-07-13 12:30:34]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-13 13:11:51]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-07-13 13:12:05]

CQ bit was unchecked.

[commit-bot: I haz the power, 2016-07-13 13:13:52]

Description was changed from

==========
Simplify protocol between SELECT elements and popups.

- Rename listBoxSelectItem to selectMultipleOptionsByPopup, and it accepts index
  vector.
- Rename valueChanged to selectOptionByPopup.

Single-selection menulist accepts only selectOptionByPopup().
Multiple-selection menulist accepts selectOptionByPopup(-1) and
selectMultipleOptionsByPopup().
==========

to

==========
Simplify protocol between SELECT elements and popups.

- Rename listBoxSelectItem to selectMultipleOptionsByPopup, and it accepts index
  vector.
- Rename valueChanged to selectOptionByPopup.

Single-selection menulist accepts only selectOptionByPopup().
Multiple-selection menulist accepts selectOptionByPopup(-1) and
selectMultipleOptionsByPopup().

Committed: https://crrev.com/bd9726939278a4ce06a29875a89b5dba9f01d2ca
Cr-Commit-Position: refs/heads/master@{#405134}
==========

[commit-bot: I haz the power, 2016-07-13 13:13:53]

Patchset 1 (id:??) landed as
https://crrev.com/bd9726939278a4ce06a29875a89b5dba9f01d2ca
Cr-Commit-Position: refs/heads/master@{#405134}

[wychen, 2016-09-29 02:42:56]

wychen@chromium.org changed reviewers:
+ wychen@chromium.org

[wychen, 2016-09-29 02:42:57]

https://codereview.chromium.org/2143863003/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/html/HTMLSelectElement.cpp (right):

https://codereview.chromium.org/2143863003/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/html/HTMLSelectElement.cpp:214:
DCHECK(!multiple());
Should this line be DCHECK(multiple())? I'm a bit confused.

[tkent, 2016-09-29 03:14:55]

https://codereview.chromium.org/2143863003/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/html/HTMLSelectElement.cpp (right):

https://codereview.chromium.org/2143863003/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/html/HTMLSelectElement.cpp:214:
DCHECK(!multiple());
On 2016/09/29 at 02:42:57, wychen wrote:
> Should this line be DCHECK(multiple())?

I think so :)