Mojo C++ bindings: rename "pass_by_value" typemap attribute to "move_only".

Mojo C++ bindings: rename "pass_by_value" typemap attribute to "move_only".

BUG=624136
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel

Committed: https://crrev.com/a17ca3553e4193720864394ce3e885fe76c77a90
Cr-Commit-Position: refs/heads/master@{#405327}

[yzshen1, 2016-07-12 22:58:28]

Description was changed from

==========
Mojo C++ bindings: rename "pass_by_value" typemap attribute to "move_only".

BUG=624136
==========

to

==========
Mojo C++ bindings: rename "pass_by_value" typemap attribute to "move_only".

BUG=624136
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
==========

[yzshen1, 2016-07-12 23:25:02]

yzshen@chromium.org changed reviewers:
+ dcheng@chromium.org

[yzshen1, 2016-07-12 23:25:03]

Hi, Daniel.

Would you please take a look? Thanks!

I understand the discussion about pass-by-value base::Time* is still on going.
But no matter whether we decide to keep "pass_by_value" or not, the types in
this CL needs to use a different annotation "move_only".

(And if you have concerns and think that one should be resolved first, I could
hold off this CL. Just let me know. Thanks!)

[dcheng, 2016-07-13 14:00:38]

On 2016/07/12 23:25:03, yzshen1 wrote:
> Hi, Daniel.
> 
> Would you please take a look? Thanks!
> 
> I understand the discussion about pass-by-value base::Time* is still on going.
> But no matter whether we decide to keep "pass_by_value" or not, the types in
> this CL needs to use a different annotation "move_only".
> 
> (And if you have concerns and think that one should be resolved first, I could
> hold off this CL. Just let me know. Thanks!)

I'm OK with this, as long you're willing to help me figure out how to update the
type mapping bindings if we decide we're ok with pass_by_value later =)

LGTM

[yzshen1, 2016-07-13 15:23:18]

On 2016/07/13 14:00:38, dcheng wrote:
> On 2016/07/12 23:25:03, yzshen1 wrote:
> > Hi, Daniel.
> > 
> > Would you please take a look? Thanks!
> > 
> > I understand the discussion about pass-by-value base::Time* is still on
going.
> > But no matter whether we decide to keep "pass_by_value" or not, the types in
> > this CL needs to use a different annotation "move_only".
> > 
> > (And if you have concerns and think that one should be resolved first, I
could
> > hold off this CL. Just let me know. Thanks!)
> 
> I'm OK with this, as long you're willing to help me figure out how to update
the
> type mapping bindings if we decide we're ok with pass_by_value later =)
> 
> LGTM

In that case, I could update the bindings code to make sure your CL can land. :)

[yzshen1, 2016-07-13 21:18:01]

The CQ bit was checked by yzshen@chromium.org

[commit-bot: I haz the power, 2016-07-13 21:18:38]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-13 21:18:39]

Your CL relies on deprecated CQ feature(s):
 * Specifying master names in CQ_INCLUDE_TRYBOTS part of description without
"master." prefix is deprecated:
     tryserver.blink
   For more details, see http://crbug.com/617627.

[yzshen1, 2016-07-13 21:30:55]

Description was changed from

==========
Mojo C++ bindings: rename "pass_by_value" typemap attribute to "move_only".

BUG=624136
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
==========

to

==========
Mojo C++ bindings: rename "pass_by_value" typemap attribute to "move_only".

BUG=624136
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
==========

[yzshen1, 2016-07-13 21:30:55]

yzshen@chromium.org changed reviewers:
+ jam@chromium.org

[yzshen1, 2016-07-13 21:32:12]

Hi, John.

Would you please do a OWNER rubberstamp for:
cc/ipc/compositor_frame.typemap
ui/events/mojo/event.typemap

This change just mechanically renames an attribute. 

Thanks!

[commit-bot: I haz the power, 2016-07-13 21:35:21]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-13 21:35:22]

Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[jam, 2016-07-13 22:16:16]

lgtm

[yzshen1, 2016-07-13 22:17:01]

The CQ bit was checked by yzshen@chromium.org

[commit-bot: I haz the power, 2016-07-13 22:18:20]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-13 22:52:47]

Description was changed from

==========
Mojo C++ bindings: rename "pass_by_value" typemap attribute to "move_only".

BUG=624136
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
==========

to

==========
Mojo C++ bindings: rename "pass_by_value" typemap attribute to "move_only".

BUG=624136
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
==========

[commit-bot: I haz the power, 2016-07-13 22:52:48]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-07-13 22:54:35]

Description was changed from

==========
Mojo C++ bindings: rename "pass_by_value" typemap attribute to "move_only".

BUG=624136
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
==========

to

==========
Mojo C++ bindings: rename "pass_by_value" typemap attribute to "move_only".

BUG=624136
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel

Committed: https://crrev.com/a17ca3553e4193720864394ce3e885fe76c77a90
Cr-Commit-Position: refs/heads/master@{#405327}
==========

[commit-bot: I haz the power, 2016-07-13 22:54:37]

Patchset 1 (id:??) landed as
https://crrev.com/a17ca3553e4193720864394ce3e885fe76c77a90
Cr-Commit-Position: refs/heads/master@{#405327}