mojo/public/tools/bindings/generators/mojom_cpp_generator.py - Issue 2147563004: Mojo C++ bindings: rename "pass_by_value" typemap attribute to "move_only".

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: mojo/public/tools/bindings/generators/mojom_cpp_generator.py

Issue 2147563004: Mojo C++ bindings: rename "pass_by_value" typemap attribute to "move_only". (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@68_native_types

Patch Set: Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: mojo/public/tools/bindings/generators/mojom_cpp_generator.py

diff --git a/mojo/public/tools/bindings/generators/mojom_cpp_generator.py b/mojo/public/tools/bindings/generators/mojom_cpp_generator.py

index 6dd429bc73f9d92988cd9d997b88148ae731e00a..38b219c61fa0a94ddd50efeec006ee9d5a88eb7f 100644

--- a/mojo/public/tools/bindings/generators/mojom_cpp_generator.py

+++ b/mojo/public/tools/bindings/generators/mojom_cpp_generator.py

@@ -216,8 +216,7 @@ def IsMoveOnlyKind(kind):

if IsTypemappedKind(kind):

if mojom.IsEnumKind(kind):

return False

- # TODO(yzshen): Change the attribute to "move_only".

- return _current_typemap[GetFullMojomNameForKind(kind)]["pass_by_value"]

+ return _current_typemap[GetFullMojomNameForKind(kind)]["move_only"]

if mojom.IsStructKind(kind) or mojom.IsUnionKind(kind):

return True

if mojom.IsArrayKind(kind):

« no previous file with comments | « mojo/public/tools/bindings/generate_type_mappings.py ('k') | ui/events/mojo/event.typemap » ('j') | no next file with comments »