mojo/public/tools/bindings/generate_type_mappings.py - Issue 2147563004: Mojo C++ bindings: rename "pass_by_value" typemap attribute to "move_only".

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: mojo/public/tools/bindings/generate_type_mappings.py

Issue 2147563004: Mojo C++ bindings: rename "pass_by_value" typemap attribute to "move_only". (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@68_native_types

Patch Set: Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « mojo/public/cpp/bindings/tests/struct_with_traits.typemap ('k') | mojo/public/tools/bindings/generators/mojom_cpp_generator.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: mojo/public/tools/bindings/generate_type_mappings.py

diff --git a/mojo/public/tools/bindings/generate_type_mappings.py b/mojo/public/tools/bindings/generate_type_mappings.py

index 77915892967cee1131c1f8a85d8cc038069b7336..e2fbf315c5da4b071adf00865c92883b9fa71222 100755

--- a/mojo/public/tools/bindings/generate_type_mappings.py

+++ b/mojo/public/tools/bindings/generate_type_mappings.py

@@ -97,9 +97,8 @@ def ParseTypemap(typemap):

mojom_type = match_result.group(1)

native_type = match_result.group(2)

- # The only attribute supported currently is "pass_by_value".

- pass_by_value = (match_result.group(3) and

- match_result.group(3) == "pass_by_value")

+ # The only attribute supported currently is "move_only".

+ move_only = match_result.group(3) and match_result.group(3) == "move_only"

assert mojom_type not in result, (

"Cannot map multiple native types (%s, %s) to the same mojom type: %s" %

@@ -107,7 +106,7 @@ def ParseTypemap(typemap):

result[mojom_type] = {

'typename': native_type,

- 'pass_by_value': pass_by_value,

+ 'move_only': move_only,

'public_headers': values['public_headers'],

'traits_headers': values['traits_headers'],

}