Mojo typemap config: support "copyable_pass_by_value" attribute.

Mojo typemap config: support "copyable_pass_by_value" attribute.

This attribute is used with copyable TrivialStruct which should be passed by
value. It is not transitive. std::vector<TrivialStruct> will be passed by const
ref, for example.

It is added because people think it is useful to make base::Time* pass by value
to be more consistent with our style requirements.

BUG=624136
Committed: https://crrev.com/955bec3b94a157ed7235df10b1fe9d474ccd193f
Cr-Commit-Position: refs/heads/master@{#406084}

[yzshen1, 2016-07-13 21:15:17]

yzshen@chromium.org changed reviewers:
+ dcheng@chromium.org, rockot@chromium.org

[yzshen1, 2016-07-13 21:15:17]

Hi, Ken and Daniel.

Please take a look. Thanks!

Ken: everything
Daniel: security (I don't think this really requires security review. Would you
please modify security owner policy to exclude mojom/struct traits for testing?)

[dcheng, 2016-07-14 02:48:43]

On 2016/07/13 21:15:17, yzshen1 wrote:
> Hi, Ken and Daniel.
> 
> Please take a look. Thanks!
> 
> Ken: everything
> Daniel: security (I don't think this really requires security review. Would
you
> please modify security owner policy to exclude mojom/struct traits for
testing?)

LGTM

As a hack, let's just add:

*.mojom=file://mojo/OWNERS

to OWNERS for tests =)

I haven't seen this come up too much outside of this set of tests, but if it's a
more comprehensive problem, I'll try to figure out a global solution.

[yzshen1, 2016-07-14 05:12:58]

On 2016/07/14 02:48:43, dcheng wrote:
> On 2016/07/13 21:15:17, yzshen1 wrote:
> > Hi, Ken and Daniel.
> > 
> > Please take a look. Thanks!
> > 
> > Ken: everything
> > Daniel: security (I don't think this really requires security review. Would
> you
> > please modify security owner policy to exclude mojom/struct traits for
> testing?)
> 
> LGTM
> 
> As a hack, let's just add:
> 
> *.mojom=file://mojo/OWNERS
> 
> to OWNERS for tests =)
> 
> I haven't seen this come up too much outside of this set of tests, but if it's
a
> more comprehensive problem, I'll try to figure out a global solution.

Thanks! That sounds good to me.  I will add that for the test folder.

[yzshen1, 2016-07-18 16:11:41]

The CQ bit was checked by yzshen@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-07-18 16:12:06]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[yzshen1, 2016-07-18 16:14:52]

The CQ bit was checked by yzshen@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-07-18 16:15:18]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[yzshen1, 2016-07-18 16:17:32]

Friendly ping, Ken.

[Ken Rockot(use gerrit already), 2016-07-18 16:20:53]

Woops, sorry, I thought I had already stamped this! LGTM

[yzshen1, 2016-07-18 16:23:08]

On 2016/07/18 16:20:53, Ken Rockot wrote:
> Woops, sorry, I thought I had already stamped this! LGTM

Thanks!

[commit-bot: I haz the power, 2016-07-18 17:03:26]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-18 17:03:27]

Dry run: Try jobs failed on following builders:
  win_clang on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_clang/builds/...)

[yzshen1, 2016-07-18 17:46:59]

The CQ bit was checked by yzshen@chromium.org

[yzshen1, 2016-07-18 17:46:59]

The patchset sent to the CQ was uploaded after l-g-t-m from dcheng@chromium.org
Link to the patchset: https://codereview.chromium.org/2146153002/#ps40001
(title: ".")

[commit-bot: I haz the power, 2016-07-18 17:47:30]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-18 19:26:09]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-18 19:26:10]

Try jobs failed on following builders:
  win_clang on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_clang/builds/...)

[yzshen1, 2016-07-18 19:27:36]

The CQ bit was checked by yzshen@chromium.org

[commit-bot: I haz the power, 2016-07-18 19:28:43]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-18 20:35:45]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-07-18 20:35:50]

CQ bit was unchecked.

[commit-bot: I haz the power, 2016-07-18 20:38:43]

Description was changed from

==========
Mojo typemap config: support "copyable_pass_by_value" attribute.

This attribute is used with copyable TrivialStruct which should be passed by
value. It is not transitive. std::vector<TrivialStruct> will be passed by const
ref, for example.

It is added because people think it is useful to make base::Time* pass by value
to be more consistent with our style requirements.

BUG=624136
==========

to

==========
Mojo typemap config: support "copyable_pass_by_value" attribute.

This attribute is used with copyable TrivialStruct which should be passed by
value. It is not transitive. std::vector<TrivialStruct> will be passed by const
ref, for example.

It is added because people think it is useful to make base::Time* pass by value
to be more consistent with our style requirements.

BUG=624136

Committed: https://crrev.com/955bec3b94a157ed7235df10b1fe9d474ccd193f
Cr-Commit-Position: refs/heads/master@{#406084}
==========

[commit-bot: I haz the power, 2016-07-18 20:38:44]

Patchset 3 (id:??) landed as
https://crrev.com/955bec3b94a157ed7235df10b1fe9d474ccd193f
Cr-Commit-Position: refs/heads/master@{#406084}