WebRTCCertificateGenerator should not use std::string.

WebRTCCertificateGenerator should not use std::string.

This avoids the string copies, std::string is also not supposed to be used like
this inside blink.

Committed: https://crrev.com/22651da9eb779fbdb60f6a8ea5decde2b805567f
Cr-Commit-Position: refs/heads/master@{#405837}

[esprehn, 2016-07-15 02:48:35]

The CQ bit was checked by esprehn@chromium.org to run a CQ dry run

[esprehn, 2016-07-15 02:48:57]

Description was changed from

==========
WebRTCCertificateGenerator should not use std::string.

BUG=
==========

to

==========
WebRTCCertificateGenerator should not use std::string.

https://codereview.chromium.org/1957293002

BUG=
==========

[commit-bot: I haz the power, 2016-07-15 02:49:03]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[esprehn, 2016-07-15 03:39:16]

Description was changed from

==========
WebRTCCertificateGenerator should not use std::string.

https://codereview.chromium.org/1957293002

BUG=
==========

to

==========
WebRTCCertificateGenerator should not use std::string.

This avoids the string copies, std::string is also not supposed to be used like
this inside blink.
==========

[esprehn, 2016-07-15 03:40:02]

esprehn@chromium.org changed reviewers:
+ jochen@chromium.org, tommi@chromium.org

[commit-bot: I haz the power, 2016-07-15 04:17:27]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-15 04:17:28]

Dry run: This issue passed the CQ dry run.

[tommi (sloooow) - chröme, 2016-07-15 14:15:45]

lgtm - I'm curious though about how much copying this will save. Looks like
we're making copies in different places now?

[jochen (gone - plz use gerrit), 2016-07-15 14:38:19]

lgtm

[esprehn, 2016-07-15 19:54:33]

On 2016/07/15 at 14:15:45, tommi wrote:
> lgtm - I'm curious though about how much copying this will save. Looks like
we're making copies in different places now?

SerializedScriptValueWriterForModules::writeRTCCertificate avoids one copy per
field by doing the conversion to WebString which is reference counted, so we
don't need to do a copy to assign the return value "WebRTCCertificatePEM pem =
certificate.certificateShallowCopy()->toPEM()" followed by a another copy doing
String(pem.privateKey().c_str()))

Note that that code was also wrong since std::string is utf8, and String's
constructor takes Latin1 bytes, you wanted fromUTF8 there.

We also avoid the copies here:

certificateGenerator->fromPEM(
        certificateGenerator->fromPEM(
            pemPrivateKey.utf8().data(),
            pemPrivateKey,
            pemCertificate.utf8().data()));

each utf8() call was doing a copy to CString, then converted to std::string was
another copy to call the function. By using .utf8() inside
RTCCertificateGenerator::fromPEM we avoid the copy to CString if the string is
all ASCII because utf8() uses StringUTF8Adaptor.

[esprehn, 2016-07-15 19:55:10]

The CQ bit was checked by esprehn@chromium.org

[commit-bot: I haz the power, 2016-07-15 19:55:43]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-15 20:03:32]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-15 20:03:34]

Failed to apply the patch.

[commit-bot: I haz the power, 2016-07-15 20:03:42]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-15 20:03:43]

CQ bit was unchecked.

[commit-bot: I haz the power, 2016-07-15 20:04:31]

Description was changed from

==========
WebRTCCertificateGenerator should not use std::string.

This avoids the string copies, std::string is also not supposed to be used like
this inside blink.
==========

to

==========
WebRTCCertificateGenerator should not use std::string.

This avoids the string copies, std::string is also not supposed to be used like
this inside blink.

Committed: https://crrev.com/22651da9eb779fbdb60f6a8ea5decde2b805567f
Cr-Commit-Position: refs/heads/master@{#405837}
==========

[commit-bot: I haz the power, 2016-07-15 20:04:32]

Patchset 1 (id:??) landed as
https://crrev.com/22651da9eb779fbdb60f6a8ea5decde2b805567f
Cr-Commit-Position: refs/heads/master@{#405837}

[tommi (sloooow) - chröme, 2016-07-15 21:09:33]

Thanks. +hbos fyi

[hbos_chromium, 2016-07-18 08:01:52]

hbos@chromium.org changed reviewers:
+ hbos@chromium.org

[hbos_chromium, 2016-07-18 08:01:52]

Thanks. (lgtm!)