Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(774)

Issue 1957293002: RTCCertificate to/from PEM string serialization. (Closed)

Created:
4 years, 7 months ago by hbos_chromium
Modified:
4 years, 5 months ago
CC:
blink-reviews, blink-reviews-api_chromium.org, chromium-reviews, darin-cc_chromium.org, dglazkov+blink, feature-media-reviews_chromium.org, jam, mkwst+moarreviews-renderer_chromium.org, mlamouri+watch-content_chromium.org, posciak+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

RTCCertificate to/from PEM string serialization. This is part of larger work that will allow persistent storage of RTCCertificate in IndexedDB. The big picture can be seen here: https://codereview.chromium.org/1949033002/ This CL implements part 1: 1. RTCCertificate to/from string a) The ToPEM and FromPEM serialization functions from the WebRTC layer that converts RTCCertificate to- and from string are made visible in the blink and content layers. b) |WebRTCCertificate::keyParams| is removed so that we don't have to serialize this or add getters for obtaining this information from the WebRTC layer's RTCCertificate. The getter was never used by anyone. BUG=581354 Committed: https://crrev.com/a9302bb5a5d8b9cce886049fff8e586660006dfd Cr-Commit-Position: refs/heads/master@{#392342}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+54 lines, -16 lines) Patch
M content/renderer/media/rtc_certificate.h View 2 chunks +2 lines, -5 lines 0 comments Download
M content/renderer/media/rtc_certificate.cc View 2 chunks +7 lines, -7 lines 0 comments Download
M content/renderer/media/rtc_certificate_generator.h View 1 chunk +3 lines, -0 lines 0 comments Download
M content/renderer/media/rtc_certificate_generator.cc View 2 chunks +11 lines, -1 line 0 comments Download
M third_party/WebKit/public/platform/WebRTCCertificate.h View 2 chunks +26 lines, -3 lines 0 comments Download
M third_party/WebKit/public/platform/WebRTCCertificateGenerator.h View 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (4 generated)
hbos_chromium
Please take a look tommi & jochen. This is another one of those CLs that ...
4 years, 7 months ago (2016-05-09 13:45:56 UTC) #2
jochen (gone - plz use gerrit)
lgtm
4 years, 7 months ago (2016-05-09 15:45:19 UTC) #3
tommi (sloooow) - chröme
lgtm
4 years, 7 months ago (2016-05-09 17:00:31 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1957293002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1957293002/1
4 years, 7 months ago (2016-05-09 17:00:50 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-05-09 17:06:01 UTC) #7
commit-bot: I haz the power
4 years, 7 months ago (2016-05-09 17:08:14 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/a9302bb5a5d8b9cce886049fff8e586660006dfd
Cr-Commit-Position: refs/heads/master@{#392342}

Powered by Google App Engine
This is Rietveld 408576698