content/renderer/media/rtc_certificate_generator.cc - Issue 2147413002: WebRTCCertificateGenerator should not use std::string.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/renderer/media/rtc_certificate_generator.cc

Issue 2147413002: WebRTCCertificateGenerator should not use std::string. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/renderer/media/rtc_certificate_generator.h ('k') | third_party/WebKit/Source/bindings/modules/v8/ScriptValueSerializerForModules.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/renderer/media/rtc_certificate_generator.cc

diff --git a/content/renderer/media/rtc_certificate_generator.cc b/content/renderer/media/rtc_certificate_generator.cc

index 94626e500638e4746d71e9c77de58e07a56db7c9..aa3f8d72c93fae0a19ea5bf5aa505de41c65b530 100644

--- a/content/renderer/media/rtc_certificate_generator.cc

+++ b/content/renderer/media/rtc_certificate_generator.cc

@@ -151,11 +151,12 @@ bool RTCCertificateGenerator::isSupportedKeyParams(

}

std::unique_ptr<blink::WebRTCCertificate> RTCCertificateGenerator::fromPEM(

- const std::string& pem_private_key,

- const std::string& pem_certificate) {

+ blink::WebString pem_private_key,

+ blink::WebString pem_certificate) {

rtc::scoped_refptr<rtc::RTCCertificate> certificate =

rtc::RTCCertificate::FromPEM(

- rtc::RTCCertificatePEM(pem_private_key, pem_certificate));

+ rtc::RTCCertificatePEM(pem_private_key.utf8(),

+ pem_certificate.utf8()));

return std::unique_ptr<blink::WebRTCCertificate>(

new RTCCertificate(certificate));

}