content/renderer/media/rtc_certificate_generator.h - Issue 2147413002: WebRTCCertificateGenerator should not use std::string.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/renderer/media/rtc_certificate_generator.h

Issue 2147413002: WebRTCCertificateGenerator should not use std::string. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: content/renderer/media/rtc_certificate_generator.h

diff --git a/content/renderer/media/rtc_certificate_generator.h b/content/renderer/media/rtc_certificate_generator.h

index 38811e5ef95c098844e91cb93ba5a88cd6d4bca8..988f349edfcbdbbdc40c3ce6c6aed4172c047600 100644

--- a/content/renderer/media/rtc_certificate_generator.h

+++ b/content/renderer/media/rtc_certificate_generator.h

@@ -31,8 +31,8 @@ class RTCCertificateGenerator : public blink::WebRTCCertificateGenerator {

std::unique_ptr<blink::WebRTCCertificateCallback> observer) override;

bool isSupportedKeyParams(const blink::WebRTCKeyParams& key_params) override;

std::unique_ptr<blink::WebRTCCertificate> fromPEM(

- const std::string& pem_private_key,

- const std::string& pem_certificate) override;

+ blink::WebString pem_private_key,

+ blink::WebString pem_certificate) override;

private:

void generateCertificateWithOptionalExpiration(

« no previous file with comments | « content/renderer/media/rtc_certificate.cc ('k') | content/renderer/media/rtc_certificate_generator.cc » ('j') | no next file with comments »