Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(14)

Issue 2147013002: [stubs] Removed "Vector" ornamentation from StoreIC stubs names. (Closed)

Created:
4 years, 5 months ago by Igor Sheludko
Modified:
4 years, 5 months ago
Reviewers:
Jakob Kummerow
CC:
v8-reviews_googlegroups.com, v8-mips-ports_googlegroups.com, v8-x87-ports_googlegroups.com, v8-ppc-ports_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[stubs] Removed "Vector" ornamentation from StoreIC stubs names. VectorStoreICStub -> StoreICStub VectorStoreICTrampolineStub -> StoreICTrampolineStub VectorKeyedStoreICStub -> KeyedStoreICStub VectorKeyedStoreICTrampolineStub -> KeyedStoreICTrampolineStub Committed: https://crrev.com/b34e6ff6c7fd084bf343d8c9b5bec76117d047a3 Cr-Commit-Position: refs/heads/master@{#37752}

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+111 lines, -197 lines) Patch
M src/arm/code-stubs-arm.cc View 3 chunks +10 lines, -20 lines 0 comments Download
M src/arm64/code-stubs-arm64.cc View 3 chunks +10 lines, -20 lines 0 comments Download
M src/code-factory.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M src/code-stubs.h View 6 chunks +17 lines, -22 lines 2 comments Download
M src/ia32/code-stubs-ia32.cc View 4 chunks +10 lines, -20 lines 0 comments Download
M src/ic/ic.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M src/mips/code-stubs-mips.cc View 3 chunks +10 lines, -20 lines 0 comments Download
M src/mips64/code-stubs-mips64.cc View 3 chunks +10 lines, -20 lines 0 comments Download
M src/ppc/code-stubs-ppc.cc View 3 chunks +10 lines, -20 lines 0 comments Download
M src/s390/code-stubs-s390.cc View 3 chunks +10 lines, -12 lines 0 comments Download
M src/x64/code-stubs-x64.cc View 3 chunks +10 lines, -20 lines 0 comments Download
M src/x87/code-stubs-x87.cc View 4 chunks +10 lines, -19 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 14 (8 generated)
Igor Sheludko
PTAL
4 years, 5 months ago (2016-07-13 19:41:37 UTC) #7
Jakob Kummerow
lgtm https://codereview.chromium.org/2147013002/diff/20001/src/code-stubs.h File src/code-stubs.h (right): https://codereview.chromium.org/2147013002/diff/20001/src/code-stubs.h#newcode2385 src/code-stubs.h:2385: DEFINE_CALL_INTERFACE_DESCRIPTOR(VectorStoreICTrampoline); future renaming?
4 years, 5 months ago (2016-07-14 09:41:59 UTC) #8
Igor Sheludko
https://codereview.chromium.org/2147013002/diff/20001/src/code-stubs.h File src/code-stubs.h (right): https://codereview.chromium.org/2147013002/diff/20001/src/code-stubs.h#newcode2385 src/code-stubs.h:2385: DEFINE_CALL_INTERFACE_DESCRIPTOR(VectorStoreICTrampoline); On 2016/07/14 09:41:59, Jakob wrote: > future renaming? ...
4 years, 5 months ago (2016-07-14 09:47:54 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2147013002/20001
4 years, 5 months ago (2016-07-14 09:48:12 UTC) #11
commit-bot: I haz the power
Committed patchset #1 (id:20001)
4 years, 5 months ago (2016-07-14 09:50:55 UTC) #12
commit-bot: I haz the power
4 years, 5 months ago (2016-07-14 09:51:28 UTC) #14
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/b34e6ff6c7fd084bf343d8c9b5bec76117d047a3
Cr-Commit-Position: refs/heads/master@{#37752}

Powered by Google App Engine
This is Rietveld 408576698