Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(73)

Unified Diff: src/code-stubs.h

Issue 2147013002: [stubs] Removed "Vector" ornamentation from StoreIC stubs names. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/code-factory.cc ('k') | src/ia32/code-stubs-ia32.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/code-stubs.h
diff --git a/src/code-stubs.h b/src/code-stubs.h
index b1d45b63e3ed78d08469005931ce894939de1a88..40b7bb0ba0bcd55665f5954f7eb8a3e2b12683fe 100644
--- a/src/code-stubs.h
+++ b/src/code-stubs.h
@@ -49,10 +49,10 @@ namespace internal {
V(ToString) \
V(ToName) \
V(ToObject) \
- V(VectorStoreICTrampoline) \
- V(VectorKeyedStoreICTrampoline) \
- V(VectorStoreIC) \
- V(VectorKeyedStoreIC) \
+ V(StoreICTrampoline) \
+ V(KeyedStoreICTrampoline) \
+ V(StoreIC) \
+ V(KeyedStoreIC) \
/* HydrogenCodeStubs */ \
V(BinaryOpIC) \
V(BinaryOpWithAllocationSite) \
@@ -2363,10 +2363,9 @@ class KeyedLoadICTrampolineStub : public LoadICTrampolineStub {
DEFINE_PLATFORM_CODE_STUB(KeyedLoadICTrampoline, LoadICTrampolineStub);
};
-
-class VectorStoreICTrampolineStub : public PlatformCodeStub {
+class StoreICTrampolineStub : public PlatformCodeStub {
public:
- VectorStoreICTrampolineStub(Isolate* isolate, const StoreICState& state)
+ StoreICTrampolineStub(Isolate* isolate, const StoreICState& state)
: PlatformCodeStub(isolate) {
minor_key_ = state.GetExtraICState();
}
@@ -2384,19 +2383,17 @@ class VectorStoreICTrampolineStub : public PlatformCodeStub {
private:
DEFINE_CALL_INTERFACE_DESCRIPTOR(VectorStoreICTrampoline);
Jakob Kummerow 2016/07/14 09:41:59 future renaming?
Igor Sheludko 2016/07/14 09:47:54 Exactly!
- DEFINE_PLATFORM_CODE_STUB(VectorStoreICTrampoline, PlatformCodeStub);
+ DEFINE_PLATFORM_CODE_STUB(StoreICTrampoline, PlatformCodeStub);
};
-
-class VectorKeyedStoreICTrampolineStub : public VectorStoreICTrampolineStub {
+class KeyedStoreICTrampolineStub : public StoreICTrampolineStub {
public:
- VectorKeyedStoreICTrampolineStub(Isolate* isolate, const StoreICState& state)
- : VectorStoreICTrampolineStub(isolate, state) {}
+ KeyedStoreICTrampolineStub(Isolate* isolate, const StoreICState& state)
+ : StoreICTrampolineStub(isolate, state) {}
Code::Kind GetCodeKind() const override { return Code::KEYED_STORE_IC; }
- DEFINE_PLATFORM_CODE_STUB(VectorKeyedStoreICTrampoline,
- VectorStoreICTrampolineStub);
+ DEFINE_PLATFORM_CODE_STUB(KeyedStoreICTrampoline, StoreICTrampolineStub);
};
@@ -2484,10 +2481,9 @@ class KeyedLoadICStub : public PlatformCodeStub {
void GenerateImpl(MacroAssembler* masm, bool in_frame);
};
-
-class VectorStoreICStub : public PlatformCodeStub {
+class StoreICStub : public PlatformCodeStub {
public:
- VectorStoreICStub(Isolate* isolate, const StoreICState& state)
+ StoreICStub(Isolate* isolate, const StoreICState& state)
: PlatformCodeStub(isolate) {
minor_key_ = state.GetExtraICState();
}
@@ -2501,16 +2497,15 @@ class VectorStoreICStub : public PlatformCodeStub {
}
DEFINE_CALL_INTERFACE_DESCRIPTOR(VectorStoreIC);
- DEFINE_PLATFORM_CODE_STUB(VectorStoreIC, PlatformCodeStub);
+ DEFINE_PLATFORM_CODE_STUB(StoreIC, PlatformCodeStub);
protected:
void GenerateImpl(MacroAssembler* masm, bool in_frame);
};
-
-class VectorKeyedStoreICStub : public PlatformCodeStub {
+class KeyedStoreICStub : public PlatformCodeStub {
public:
- VectorKeyedStoreICStub(Isolate* isolate, const StoreICState& state)
+ KeyedStoreICStub(Isolate* isolate, const StoreICState& state)
: PlatformCodeStub(isolate) {
minor_key_ = state.GetExtraICState();
}
@@ -2524,7 +2519,7 @@ class VectorKeyedStoreICStub : public PlatformCodeStub {
}
DEFINE_CALL_INTERFACE_DESCRIPTOR(VectorStoreIC);
- DEFINE_PLATFORM_CODE_STUB(VectorKeyedStoreIC, PlatformCodeStub);
+ DEFINE_PLATFORM_CODE_STUB(KeyedStoreIC, PlatformCodeStub);
protected:
void GenerateImpl(MacroAssembler* masm, bool in_frame);
« no previous file with comments | « src/code-factory.cc ('k') | src/ia32/code-stubs-ia32.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698