Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(47)

Side by Side Diff: src/arm/code-stubs-arm.cc

Issue 2147013002: [stubs] Removed "Vector" ornamentation from StoreIC stubs names. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | src/arm64/code-stubs-arm64.cc » ('j') | src/code-stubs.h » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #if V8_TARGET_ARCH_ARM 5 #if V8_TARGET_ARCH_ARM
6 6
7 #include "src/code-stubs.h" 7 #include "src/code-stubs.h"
8 #include "src/api-arguments.h" 8 #include "src/api-arguments.h"
9 #include "src/base/bits.h" 9 #include "src/base/bits.h"
10 #include "src/bootstrapper.h" 10 #include "src/bootstrapper.h"
(...skipping 3587 matching lines...) Expand 10 before | Expand all | Expand 10 after
3598 HandleArrayCases(masm, feedback, receiver_map, scratch1, r9, false, &miss); 3598 HandleArrayCases(masm, feedback, receiver_map, scratch1, r9, false, &miss);
3599 3599
3600 __ bind(&miss); 3600 __ bind(&miss);
3601 KeyedLoadIC::GenerateMiss(masm); 3601 KeyedLoadIC::GenerateMiss(masm);
3602 3602
3603 __ bind(&load_smi_map); 3603 __ bind(&load_smi_map);
3604 __ LoadRoot(receiver_map, Heap::kHeapNumberMapRootIndex); 3604 __ LoadRoot(receiver_map, Heap::kHeapNumberMapRootIndex);
3605 __ jmp(&compare_map); 3605 __ jmp(&compare_map);
3606 } 3606 }
3607 3607
3608 3608 void StoreICTrampolineStub::Generate(MacroAssembler* masm) {
3609 void VectorStoreICTrampolineStub::Generate(MacroAssembler* masm) {
3610 __ EmitLoadTypeFeedbackVector(VectorStoreICDescriptor::VectorRegister()); 3609 __ EmitLoadTypeFeedbackVector(VectorStoreICDescriptor::VectorRegister());
3611 VectorStoreICStub stub(isolate(), state()); 3610 StoreICStub stub(isolate(), state());
3612 stub.GenerateForTrampoline(masm); 3611 stub.GenerateForTrampoline(masm);
3613 } 3612 }
3614 3613
3615 3614 void KeyedStoreICTrampolineStub::Generate(MacroAssembler* masm) {
3616 void VectorKeyedStoreICTrampolineStub::Generate(MacroAssembler* masm) {
3617 __ EmitLoadTypeFeedbackVector(VectorStoreICDescriptor::VectorRegister()); 3615 __ EmitLoadTypeFeedbackVector(VectorStoreICDescriptor::VectorRegister());
3618 VectorKeyedStoreICStub stub(isolate(), state()); 3616 KeyedStoreICStub stub(isolate(), state());
3619 stub.GenerateForTrampoline(masm); 3617 stub.GenerateForTrampoline(masm);
3620 } 3618 }
3621 3619
3620 void StoreICStub::Generate(MacroAssembler* masm) { GenerateImpl(masm, false); }
3622 3621
3623 void VectorStoreICStub::Generate(MacroAssembler* masm) { 3622 void StoreICStub::GenerateForTrampoline(MacroAssembler* masm) {
3624 GenerateImpl(masm, false);
3625 }
3626
3627
3628 void VectorStoreICStub::GenerateForTrampoline(MacroAssembler* masm) {
3629 GenerateImpl(masm, true); 3623 GenerateImpl(masm, true);
3630 } 3624 }
3631 3625
3632 3626 void StoreICStub::GenerateImpl(MacroAssembler* masm, bool in_frame) {
3633 void VectorStoreICStub::GenerateImpl(MacroAssembler* masm, bool in_frame) {
3634 Register receiver = VectorStoreICDescriptor::ReceiverRegister(); // r1 3627 Register receiver = VectorStoreICDescriptor::ReceiverRegister(); // r1
3635 Register key = VectorStoreICDescriptor::NameRegister(); // r2 3628 Register key = VectorStoreICDescriptor::NameRegister(); // r2
3636 Register vector = VectorStoreICDescriptor::VectorRegister(); // r3 3629 Register vector = VectorStoreICDescriptor::VectorRegister(); // r3
3637 Register slot = VectorStoreICDescriptor::SlotRegister(); // r4 3630 Register slot = VectorStoreICDescriptor::SlotRegister(); // r4
3638 DCHECK(VectorStoreICDescriptor::ValueRegister().is(r0)); // r0 3631 DCHECK(VectorStoreICDescriptor::ValueRegister().is(r0)); // r0
3639 Register feedback = r5; 3632 Register feedback = r5;
3640 Register receiver_map = r6; 3633 Register receiver_map = r6;
3641 Register scratch1 = r9; 3634 Register scratch1 = r9;
3642 3635
3643 __ add(feedback, vector, Operand::PointerOffsetFromSmiKey(slot)); 3636 __ add(feedback, vector, Operand::PointerOffsetFromSmiKey(slot));
(...skipping 27 matching lines...) Expand all
3671 masm, receiver, key, feedback, receiver_map, scratch1, scratch2); 3664 masm, receiver, key, feedback, receiver_map, scratch1, scratch2);
3672 3665
3673 __ bind(&miss); 3666 __ bind(&miss);
3674 StoreIC::GenerateMiss(masm); 3667 StoreIC::GenerateMiss(masm);
3675 3668
3676 __ bind(&load_smi_map); 3669 __ bind(&load_smi_map);
3677 __ LoadRoot(receiver_map, Heap::kHeapNumberMapRootIndex); 3670 __ LoadRoot(receiver_map, Heap::kHeapNumberMapRootIndex);
3678 __ jmp(&compare_map); 3671 __ jmp(&compare_map);
3679 } 3672 }
3680 3673
3681 3674 void KeyedStoreICStub::Generate(MacroAssembler* masm) {
3682 void VectorKeyedStoreICStub::Generate(MacroAssembler* masm) {
3683 GenerateImpl(masm, false); 3675 GenerateImpl(masm, false);
3684 } 3676 }
3685 3677
3686 3678 void KeyedStoreICStub::GenerateForTrampoline(MacroAssembler* masm) {
3687 void VectorKeyedStoreICStub::GenerateForTrampoline(MacroAssembler* masm) {
3688 GenerateImpl(masm, true); 3679 GenerateImpl(masm, true);
3689 } 3680 }
3690 3681
3691 3682
3692 static void HandlePolymorphicStoreCase(MacroAssembler* masm, Register feedback, 3683 static void HandlePolymorphicStoreCase(MacroAssembler* masm, Register feedback,
3693 Register receiver_map, Register scratch1, 3684 Register receiver_map, Register scratch1,
3694 Register scratch2, Label* miss) { 3685 Register scratch2, Label* miss) {
3695 // feedback initially contains the feedback array 3686 // feedback initially contains the feedback array
3696 Label next_loop, prepare_next; 3687 Label next_loop, prepare_next;
3697 Label start_polymorphic; 3688 Label start_polymorphic;
(...skipping 45 matching lines...) Expand 10 before | Expand all | Expand 10 after
3743 3734
3744 __ bind(&prepare_next); 3735 __ bind(&prepare_next);
3745 __ add(pointer_reg, pointer_reg, Operand(kPointerSize * 3)); 3736 __ add(pointer_reg, pointer_reg, Operand(kPointerSize * 3));
3746 __ cmp(pointer_reg, too_far); 3737 __ cmp(pointer_reg, too_far);
3747 __ b(lt, &next_loop); 3738 __ b(lt, &next_loop);
3748 3739
3749 // We exhausted our array of map handler pairs. 3740 // We exhausted our array of map handler pairs.
3750 __ jmp(miss); 3741 __ jmp(miss);
3751 } 3742 }
3752 3743
3753 3744 void KeyedStoreICStub::GenerateImpl(MacroAssembler* masm, bool in_frame) {
3754 void VectorKeyedStoreICStub::GenerateImpl(MacroAssembler* masm, bool in_frame) {
3755 Register receiver = VectorStoreICDescriptor::ReceiverRegister(); // r1 3745 Register receiver = VectorStoreICDescriptor::ReceiverRegister(); // r1
3756 Register key = VectorStoreICDescriptor::NameRegister(); // r2 3746 Register key = VectorStoreICDescriptor::NameRegister(); // r2
3757 Register vector = VectorStoreICDescriptor::VectorRegister(); // r3 3747 Register vector = VectorStoreICDescriptor::VectorRegister(); // r3
3758 Register slot = VectorStoreICDescriptor::SlotRegister(); // r4 3748 Register slot = VectorStoreICDescriptor::SlotRegister(); // r4
3759 DCHECK(VectorStoreICDescriptor::ValueRegister().is(r0)); // r0 3749 DCHECK(VectorStoreICDescriptor::ValueRegister().is(r0)); // r0
3760 Register feedback = r5; 3750 Register feedback = r5;
3761 Register receiver_map = r6; 3751 Register receiver_map = r6;
3762 Register scratch1 = r9; 3752 Register scratch1 = r9;
3763 3753
3764 __ add(feedback, vector, Operand::PointerOffsetFromSmiKey(slot)); 3754 __ add(feedback, vector, Operand::PointerOffsetFromSmiKey(slot));
(...skipping 1474 matching lines...) Expand 10 before | Expand all | Expand 10 after
5239 CallApiFunctionAndReturn(masm, api_function_address, thunk_ref, 5229 CallApiFunctionAndReturn(masm, api_function_address, thunk_ref,
5240 kStackUnwindSpace, NULL, return_value_operand, NULL); 5230 kStackUnwindSpace, NULL, return_value_operand, NULL);
5241 } 5231 }
5242 5232
5243 #undef __ 5233 #undef __
5244 5234
5245 } // namespace internal 5235 } // namespace internal
5246 } // namespace v8 5236 } // namespace v8
5247 5237
5248 #endif // V8_TARGET_ARCH_ARM 5238 #endif // V8_TARGET_ARCH_ARM
OLDNEW
« no previous file with comments | « no previous file | src/arm64/code-stubs-arm64.cc » ('j') | src/code-stubs.h » ('J')

Powered by Google App Engine
This is Rietveld 408576698