Use :rfc1034identifier modifier to remove '_' in BUNDLE_ID_TEST_NAME.

Use :rfc1034identifier modifier to remove '_' in BUNDLE_ID_TEST_NAME.

When building with "gn", there is no way to perform the substitution
using shell commands to remove underscore from BUNDLE_ID_TEST_NAME,
so instead use :rfc1034identifier modifier implemented by the scripts
used both gyp and gn to perform substitutions in Info.plist files.

BUG=625875
Committed: https://crrev.com/727206c66f12e422f3cea79fe83ffd25e24aeabf
Cr-Commit-Position: refs/heads/master@{#405146}

[sdefresne, 2016-07-12 13:38:21]

sdefresne@chromium.org changed reviewers:
+ lod@chromium.org

[sdefresne, 2016-07-12 13:38:22]

Please take a look.

[lody, 2016-07-12 15:26:29]

lgtm

[sdefresne, 2016-07-13 10:15:53]

sdefresne@chromium.org changed reviewers:
+ phajdan.jr@chromium.org

[sdefresne, 2016-07-13 10:15:54]

Paweł can you review as OWNERS of //testing?

[Paweł Hajdan Jr., 2016-07-13 11:00:36]

LGTM

[sdefresne, 2016-07-13 11:23:59]

The CQ bit was checked by sdefresne@chromium.org

[commit-bot: I haz the power, 2016-07-13 11:24:18]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[sdefresne, 2016-07-13 11:29:13]

The CQ bit was unchecked by sdefresne@chromium.org

[sdefresne, 2016-07-13 13:31:42]

The CQ bit was checked by sdefresne@chromium.org

[commit-bot: I haz the power, 2016-07-13 13:32:25]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-13 14:40:42]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-07-13 14:40:46]

CQ bit was unchecked.

[commit-bot: I haz the power, 2016-07-13 14:42:01]

Description was changed from

==========
Use :rfc1034identifier modifier to remove '_' in BUNDLE_ID_TEST_NAME.

When building with "gn", there is no way to perform the substitution
using shell commands to remove underscore from BUNDLE_ID_TEST_NAME,
so instead use :rfc1034identifier modifier implemented by the scripts
used both gyp and gn to perform substitutions in Info.plist files.

BUG=625875
==========

to

==========
Use :rfc1034identifier modifier to remove '_' in BUNDLE_ID_TEST_NAME.

When building with "gn", there is no way to perform the substitution
using shell commands to remove underscore from BUNDLE_ID_TEST_NAME,
so instead use :rfc1034identifier modifier implemented by the scripts
used both gyp and gn to perform substitutions in Info.plist files.

BUG=625875

Committed: https://crrev.com/727206c66f12e422f3cea79fe83ffd25e24aeabf
Cr-Commit-Position: refs/heads/master@{#405146}
==========

[commit-bot: I haz the power, 2016-07-13 14:42:15]

Patchset 1 (id:??) landed as
https://crrev.com/727206c66f12e422f3cea79fe83ffd25e24aeabf
Cr-Commit-Position: refs/heads/master@{#405146}