Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(749)

Unified Diff: testing/gtest.gyp

Issue 2146483002: Use :rfc1034identifier modifier to remove '_' in BUNDLE_ID_TEST_NAME. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@{1}
Patch Set: Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | testing/gtest_ios/unittest-Info.plist » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: testing/gtest.gyp
diff --git a/testing/gtest.gyp b/testing/gtest.gyp
index d61772ecbe23323760e2a22a8364697bf88cbe29..dd9435eab57e82cb654af398456d989f031c111b 100644
--- a/testing/gtest.gyp
+++ b/testing/gtest.gyp
@@ -64,8 +64,7 @@
},
'mac_bundle': 1,
'xcode_settings': {
- 'BUNDLE_ID_TEST_NAME':
- '>!(echo ">(_target_name)" | sed -e "s/_//g")',
+ 'BUNDLE_ID_TEST_NAME': '>(_target_name)',
'INFOPLIST_FILE': '>(ios_unittest_info_plist_path)',
},
'mac_bundle_resources': [
« no previous file with comments | « no previous file | testing/gtest_ios/unittest-Info.plist » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698