Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(74)

Side by Side Diff: testing/gtest.gyp

Issue 2146483002: Use :rfc1034identifier modifier to remove '_' in BUNDLE_ID_TEST_NAME. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@{1}
Patch Set: Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | testing/gtest_ios/unittest-Info.plist » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 # Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 { 5 {
6 'includes': [ 6 'includes': [
7 'gtest.gypi', 7 'gtest.gypi',
8 ], 8 ],
9 'targets': [ 9 'targets': [
10 { 10 {
(...skipping 46 matching lines...) Expand 10 before | Expand all | Expand 10 after
57 # type of executable supported for iOS. 57 # type of executable supported for iOS.
58 ['_type=="executable"', { 58 ['_type=="executable"', {
59 'variables': { 59 'variables': {
60 # Use a variable so the path gets fixed up so it is always 60 # Use a variable so the path gets fixed up so it is always
61 # correct when INFOPLIST_FILE finally gets set. 61 # correct when INFOPLIST_FILE finally gets set.
62 'ios_unittest_info_plist_path': 62 'ios_unittest_info_plist_path':
63 '<(DEPTH)/testing/gtest_ios/unittest-Info.plist', 63 '<(DEPTH)/testing/gtest_ios/unittest-Info.plist',
64 }, 64 },
65 'mac_bundle': 1, 65 'mac_bundle': 1,
66 'xcode_settings': { 66 'xcode_settings': {
67 'BUNDLE_ID_TEST_NAME': 67 'BUNDLE_ID_TEST_NAME': '>(_target_name)',
68 '>!(echo ">(_target_name)" | sed -e "s/_//g")',
69 'INFOPLIST_FILE': '>(ios_unittest_info_plist_path)', 68 'INFOPLIST_FILE': '>(ios_unittest_info_plist_path)',
70 }, 69 },
71 'mac_bundle_resources': [ 70 'mac_bundle_resources': [
72 '<(ios_unittest_info_plist_path)', 71 '<(ios_unittest_info_plist_path)',
73 '<(DEPTH)/testing/gtest_ios/Default.png', 72 '<(DEPTH)/testing/gtest_ios/Default.png',
74 ], 73 ],
75 'mac_bundle_resources!': [ 74 'mac_bundle_resources!': [
76 '<(ios_unittest_info_plist_path)', 75 '<(ios_unittest_info_plist_path)',
77 ], 76 ],
78 }], 77 }],
(...skipping 126 matching lines...) Expand 10 before | Expand all | Expand 10 after
205 { 204 {
206 'target_name': 'gtest_prod', 205 'target_name': 'gtest_prod',
207 'toolsets': ['host', 'target'], 206 'toolsets': ['host', 'target'],
208 'type': 'none', 207 'type': 'none',
209 'sources': [ 208 'sources': [
210 'gtest/include/gtest/gtest_prod.h', 209 'gtest/include/gtest/gtest_prod.h',
211 ], 210 ],
212 }, 211 },
213 ], 212 ],
214 } 213 }
OLDNEW
« no previous file with comments | « no previous file | testing/gtest_ios/unittest-Info.plist » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698