Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1774)

Unified Diff: testing/gtest_ios/unittest-Info.plist

Issue 2146483002: Use :rfc1034identifier modifier to remove '_' in BUNDLE_ID_TEST_NAME. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@{1}
Patch Set: Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « testing/gtest.gyp ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: testing/gtest_ios/unittest-Info.plist
diff --git a/testing/gtest_ios/unittest-Info.plist b/testing/gtest_ios/unittest-Info.plist
index f3c38c88d1fe98993c7db7dfa12196448a162ec8..dc34aa0013c7dbbda71c3786b3de8f1c15d5b3f3 100644
--- a/testing/gtest_ios/unittest-Info.plist
+++ b/testing/gtest_ios/unittest-Info.plist
@@ -9,7 +9,7 @@
<key>CFBundleExecutable</key>
<string>${EXECUTABLE_NAME}</string>
<key>CFBundleIdentifier</key>
- <string>com.google.gtest.${BUNDLE_ID_TEST_NAME}</string>
+ <string>com.google.gtest.${BUNDLE_ID_TEST_NAME:rfc1034identifier}</string>
<key>CFBundleInfoDictionaryVersion</key>
<string>6.0</string>
<key>CFBundleName</key>
@@ -57,8 +57,8 @@
<true/>
<key>NSAppTransportSecurity</key>
<dict>
- <key>NSAllowsArbitraryLoads</key>
- <true/>
+ <key>NSAllowsArbitraryLoads</key>
+ <true/>
</dict>
<key>NSMainNibFile</key>
<string>${MAIN_NIB_FILE}</string>
@@ -151,10 +151,10 @@
<dict>
<key>CFBundleURLSchemes</key>
<array>
- <string>${BUNDLE_ID_TEST_NAME}.http</string>
- <string>${BUNDLE_ID_TEST_NAME}.https</string>
- <string>${BUNDLE_ID_TEST_NAME}-x-callback</string>
- <string>com.google.sso.${BUNDLE_ID_TEST_NAME}</string>
+ <string>${BUNDLE_ID_TEST_NAME:rfc1034identifier}.http</string>
+ <string>${BUNDLE_ID_TEST_NAME:rfc1034identifier}.https</string>
+ <string>${BUNDLE_ID_TEST_NAME:rfc1034identifier}-x-callback</string>
+ <string>com.google.sso.${BUNDLE_ID_TEST_NAME:rfc1034identifier}</string>
</array>
</dict>
</array>
@@ -186,7 +186,7 @@
<array>
<string>fetch</string>
</array>
- <key>SSOAuthURLScheme</key>
- <string>com.google.sso.${BUNDLE_ID_TEST_NAME}</string>
+ <key>SSOAuthURLScheme</key>
+ <string>com.google.sso.${BUNDLE_ID_TEST_NAME:rfc1034identifier}</string>
</dict>
</plist>
« no previous file with comments | « testing/gtest.gyp ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698