Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(713)

Issue 2144603003: Move fpdfsdk/jsapi into fxjs/ (Closed)

Created:
4 years, 5 months ago by dsinclair
Modified:
4 years, 5 months ago
Reviewers:
Tom Sepez, Wei Li
CC:
pdfium-reviews_googlegroups.com
Base URL:
https://pdfium.googlesource.com/pdfium.git@fxjs_v8_v2_p2
Target Ref:
refs/heads/master
Project:
pdfium
Visibility:
Public.

Description

Move fpdfsdk/jsapi into fxjs/ This CL moves the fpdfsdk/sjapi code info fxjs/. The "fxjs" library is moved from being XFA specific to being compiled if V8 is enabled. The fxjs_v8 files are required when building for XFA (they have XFA defines in them) and are used in CFXJS_RuntimeData. The cfxjse_* files are only added if XFA is also enabled. Committed: https://pdfium.googlesource.com/pdfium/+/b3f2467e065fdb36ae7c46e0a3e0b2902c8eb7f8

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+88 lines, -1324 lines) Patch
M BUILD.gn View 5 chunks +29 lines, -35 lines 0 comments Download
M fpdfsdk/javascript/JS_Define.h View 1 chunk +1 line, -1 line 0 comments Download
M fpdfsdk/javascript/JS_Object.h View 1 chunk +1 line, -1 line 0 comments Download
M fpdfsdk/javascript/JS_Value.h View 1 chunk +1 line, -1 line 0 comments Download
M fpdfsdk/javascript/cjs_runtime.h View 1 chunk +1 line, -1 line 0 comments Download
D fpdfsdk/jsapi/fxjs_v8.cpp View 1 chunk +0 lines, -856 lines 0 comments Download
D fpdfsdk/jsapi/fxjs_v8_embeddertest.cpp View 1 chunk +0 lines, -83 lines 0 comments Download
D fpdfsdk/jsapi/include/fxjs_v8.h View 1 chunk +0 lines, -290 lines 0 comments Download
M fxjs/DEPS View 1 chunk +0 lines, -2 lines 0 comments Download
M fxjs/cfxjse_runtimedata.cpp View 1 chunk +1 line, -1 line 0 comments Download
A + fxjs/fxjs_v8.cpp View 2 chunks +3 lines, -3 lines 0 comments Download
A + fxjs/fxjs_v8_embeddertest.cpp View 0 chunks +-1 lines, --1 lines 0 comments Download
A + fxjs/include/fxjs_v8.h View 2 chunks +3 lines, -3 lines 0 comments Download
M pdfium.gyp View 4 chunks +47 lines, -11 lines 0 comments Download
M testing/DEPS View 1 chunk +1 line, -1 line 0 comments Download
M testing/js_embedder_test.h View 1 chunk +1 line, -1 line 0 comments Download
M xfa.gyp View 2 chunks +0 lines, -35 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 9 (5 generated)
dsinclair
PTAL. This is the 3rd Cl which finally moves fpdfsdk/jsapi into fxjs/.
4 years, 5 months ago (2016-07-12 14:50:17 UTC) #4
Tom Sepez
lgtm
4 years, 5 months ago (2016-07-12 16:52:42 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2144603003/40001
4 years, 5 months ago (2016-07-12 17:41:59 UTC) #7
commit-bot: I haz the power
4 years, 5 months ago (2016-07-12 17:42:17 UTC) #9
Message was sent while issue was closed.
Committed patchset #1 (id:40001) as
https://pdfium.googlesource.com/pdfium/+/b3f2467e065fdb36ae7c46e0a3e0b2902c8e...

Powered by Google App Engine
This is Rietveld 408576698