Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(233)

Issue 2136273002: Create an fxjs static library (Closed)

Created:
4 years, 5 months ago by dsinclair
Modified:
4 years, 5 months ago
Reviewers:
Tom Sepez, Wei Li
CC:
pdfium-reviews_googlegroups.com
Base URL:
https://pdfium.googlesource.com/pdfium.git@fxjs_v8_v2
Target Ref:
refs/heads/master
Project:
pdfium
Visibility:
Public.

Description

Create an fxjs static library This CL moves the fxjs/ code out of the xfa library and into a fxjs library. Committed: https://pdfium.googlesource.com/pdfium/+/7f9c8609999bf3bd0b33b5b350fb9baa008cf967

Patch Set 1 #

Patch Set 2 : GYP fix attempt #

Unified diffs Side-by-side diffs Delta from patch set Stats (+52 lines, -27 lines) Patch
M BUILD.gn View 3 chunks +30 lines, -19 lines 0 comments Download
M xfa.gyp View 1 2 chunks +22 lines, -8 lines 0 comments Download

Depends on Patchset:

Dependent Patchsets:

Messages

Total messages: 8 (3 generated)
dsinclair
PTAL. This creates the fxjs library when XFA is enabled. It only contains what is ...
4 years, 5 months ago (2016-07-12 13:40:08 UTC) #2
Tom Sepez
On 2016/07/12 13:40:08, dsinclair wrote: > PTAL. This creates the fxjs library when XFA is ...
4 years, 5 months ago (2016-07-12 16:49:19 UTC) #3
Tom Sepez
lgtm
4 years, 5 months ago (2016-07-12 16:49:24 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2136273002/20001
4 years, 5 months ago (2016-07-12 17:41:28 UTC) #6
commit-bot: I haz the power
4 years, 5 months ago (2016-07-12 17:41:47 UTC) #8
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://pdfium.googlesource.com/pdfium/+/7f9c8609999bf3bd0b33b5b350fb9baa008c...

Powered by Google App Engine
This is Rietveld 408576698