Side by Side Diff
Use n/p to move between diff chunks; N/P to move between comments.
Draft comments are only viewable by you.
Keyboard Shortcuts
File
u
:
up to issue
j
/
k
:
jump to file after / before current file
J
/
K
:
jump to next file with a comment after / before current file
Side-by-side diff
i
:
toggle intra-line diffs
e
:
expand all comments
c
:
collapse all comments
s
:
toggle showing all comments
n
/
p
:
next / previous diff chunk or comment
N
/
P
:
next / previous comment
<Up>
/
<Down>
:
next / previous line
Issue
u
:
up to list of issues
j
/
k
:
jump to patch after / before current patch
o
/
<Enter>
:
open current patch in side-by-side view
i
:
open current patch in unified diff view
Issue List
j
/
k
:
jump to issue after / before current issue
o
/
<Enter>
:
open current issue
Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr)
|
Please choose your nickname with
Settings
|
Help
|
Chromium Project
|
Gerrit Changes
|
Sign out
(463)
Issues
Search
My Issues
|
Starred
Open
|
Closed
|
All
Side by Side Diff: fxjs/DEPS
Issue
2144603003
:
Move fpdfsdk/jsapi into fxjs/ (Closed)
Base URL: https://pdfium.googlesource.com/pdfium.git@fxjs_v8_v2_p2
Patch Set:
Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments.
Draft comments are only viewable by you.
Context:
3 lines
10 lines
25 lines
50 lines
75 lines
100 lines
Whole file
Column Width:
Tab Spaces:
Jump to:
BUILD.gn
fpdfsdk/javascript/JS_Define.h
fpdfsdk/javascript/JS_Object.h
fpdfsdk/javascript/JS_Value.h
fpdfsdk/javascript/cjs_runtime.h
fpdfsdk/jsapi/fxjs_v8.cpp
fpdfsdk/jsapi/fxjs_v8_embeddertest.cpp
fpdfsdk/jsapi/include/fxjs_v8.h
fxjs/DEPS
fxjs/cfxjse_runtimedata.cpp
fxjs/fxjs_v8.cpp
fxjs/fxjs_v8_embeddertest.cpp
fxjs/include/fxjs_v8.h
pdfium.gyp
testing/DEPS
testing/js_embedder_test.h
xfa.gyp
View unified diff
|
Download patch
« no previous file with comments
|
« fpdfsdk/jsapi/include/fxjs_v8.h
('k') |
fxjs/cfxjse_runtimedata.cpp »
('j') |
no next file with comments »
Toggle Intra-line Diffs
('i') |
Expand Comments
('e') |
Collapse Comments
('c') |
Show Comments
Hide Comments
('s')
OLD
NEW
1 include_rules = [
1 include_rules = [
2 '+core/fxcrt/include',
2 '+core/fxcrt/include',
3
# TODO(dsinclair): Layering violation. FXJSE can't include FPDFSDK.
4
'+fpdfsdk/jsapi/include',
5 '+v8/include',
3 '+v8/include',
6 ]
4 ]
OLD
NEW
« no previous file with comments
|
« fpdfsdk/jsapi/include/fxjs_v8.h
('k') |
fxjs/cfxjse_runtimedata.cpp »
('j') |
no next file with comments »
Issue 2144603003: Move fpdfsdk/jsapi into fxjs/ (Closed)
Created 4 years, 5 months ago by dsinclair
Modified 4 years, 5 months ago
Reviewers: Tom Sepez, Wei Li
Base URL: https://pdfium.googlesource.com/pdfium.git@fxjs_v8_v2_p2
Comments: 0
This is Rietveld
408576698