Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(185)

Unified Diff: BUILD.gn

Issue 2144603003: Move fpdfsdk/jsapi into fxjs/ (Closed) Base URL: https://pdfium.googlesource.com/pdfium.git@fxjs_v8_v2_p2
Patch Set: Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | fpdfsdk/javascript/JS_Define.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: BUILD.gn
diff --git a/BUILD.gn b/BUILD.gn
index a45bea973c51ba3fb04a3ac726f89f4db6c5d325..b54b6100165eb02288b7ae9f5e487cf208adcce6 100644
--- a/BUILD.gn
+++ b/BUILD.gn
@@ -826,15 +826,9 @@ static_library("javascript") {
"fpdfsdk/javascript/resource.h",
"fpdfsdk/javascript/util.cpp",
"fpdfsdk/javascript/util.h",
- "fpdfsdk/jsapi/fxjs_v8.cpp",
- "fpdfsdk/jsapi/include/fxjs_v8.h",
]
- include_dirs = [
- "//v8",
- "//v8/include",
- ]
- public_deps = [
- "//v8",
+ deps = [
+ ":fxjs",
]
configs += [ "//v8:external_startup_data" ]
} else {
@@ -867,25 +861,32 @@ static_library("formfiller") {
configs += [ ":pdfium_core_config" ]
}
-if (pdf_enable_xfa) {
+if (pdf_enable_v8) {
static_library("fxjs") {
sources = [
- "fxjs/cfxjse_arguments.cpp",
- "fxjs/cfxjse_class.cpp",
- "fxjs/cfxjse_context.cpp",
- "fxjs/cfxjse_isolatetracker.cpp",
- "fxjs/cfxjse_isolatetracker.h",
- "fxjs/cfxjse_runtimedata.cpp",
- "fxjs/cfxjse_runtimedata.h",
- "fxjs/cfxjse_value.cpp",
- "fxjs/include/cfxjse_arguments.h",
- "fxjs/include/cfxjse_class.h",
- "fxjs/include/cfxjse_context.h",
- "fxjs/include/cfxjse_value.h",
- "fxjs/include/fxjse.h",
+ "fxjs/fxjs_v8.cpp",
+ "fxjs/include/fxjs_v8.h",
]
+ if (pdf_enable_xfa) {
+ sources += [
+ "fxjs/cfxjse_arguments.cpp",
+ "fxjs/cfxjse_class.cpp",
+ "fxjs/cfxjse_context.cpp",
+ "fxjs/cfxjse_isolatetracker.cpp",
+ "fxjs/cfxjse_isolatetracker.h",
+ "fxjs/cfxjse_runtimedata.cpp",
+ "fxjs/cfxjse_runtimedata.h",
+ "fxjs/cfxjse_value.cpp",
+ "fxjs/include/cfxjse_arguments.h",
+ "fxjs/include/cfxjse_class.h",
+ "fxjs/include/cfxjse_context.h",
+ "fxjs/include/cfxjse_value.h",
+ "fxjs/include/fxjse.h",
+ ]
+ }
deps = [
- "//v8:v8_libplatform",
+ "//v8",
+ "//v8:v8_libplatform",
]
configs += [ ":pdfium_core_config" ]
include_dirs = [
@@ -896,7 +897,9 @@ if (pdf_enable_xfa) {
"//v8",
]
}
+}
+if (pdf_enable_xfa) {
static_library("fpdfxfa") {
sources = [
"fpdfsdk/fpdfxfa/fpdfxfa_app.cpp",
@@ -1454,9 +1457,7 @@ if (pdf_enable_xfa) {
"xfa/fxgraphics/cfx_shading.h",
"xfa/fxgraphics/include/cfx_graphics.h",
]
- include_dirs = [
- ".",
- ]
+ include_dirs = [ "." ]
deps = [
":fxjs",
]
@@ -1563,18 +1564,11 @@ test("pdfium_embeddertests") {
if (pdf_enable_v8) {
sources += [
"fpdfsdk/javascript/public_methods_embeddertest.cpp",
- "fpdfsdk/jsapi/fxjs_v8_embeddertest.cpp",
+ "fxjs/fxjs_v8_embeddertest.cpp",
"testing/js_embedder_test.cpp",
"testing/js_embedder_test.h",
]
- deps += [
- "//v8",
- "//v8:v8_libplatform",
- ]
- include_dirs += [
- "//v8",
- "//v8/include",
- ]
+ deps += [ ":fxjs" ]
configs += [ "//v8:external_startup_data" ]
}
configs += [ ":pdfium_core_config" ]
« no previous file with comments | « no previous file | fpdfsdk/javascript/JS_Define.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698