Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2144413004:
Removes abuse of createClosure() from ScriptPromiseTest. (Closed)
|
Created:
4 years, 5 months ago by Yuki Modified:
4 years, 5 months ago Reviewers:
haraken CC:
chromium-reviews, blink-reviews, blink-reviews-bindings_chromium.org Base URL:
https://chromium.googlesource.com/chromium/src.git@master Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionRemoves abuse of createClosure() from ScriptPromiseTest.
createClosure() is abused in ScriptPromise{,Resolver}Test,
so, simply removes it.
BUG=626266
Committed: https://crrev.com/6e8f53e38e8a711e7662626b3dd3fa5fd0106701
Cr-Commit-Position: refs/heads/master@{#407109}
Patch Set 1 #Patch Set 2 : . #Patch Set 3 : Synced. #Patch Set 4 : Clear a possible exception in dtor. #Patch Set 5 : Clear a possible exception in dtor. #Patch Set 6 : Clear a possible exception in dtor. #Patch Set 7 : . #
Total comments: 2
Patch Set 8 : Addressed a review comment. #
Messages
Total messages: 36 (30 generated)
The CQ bit was checked by yukishiino@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
The CQ bit was checked by yukishiino@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
The CQ bit was checked by yukishiino@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: chromeos_amd64-generic_chromium_compile_only_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_amd64-...)
The CQ bit was checked by yukishiino@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
The CQ bit was checked by yukishiino@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Description was changed from
==========
Removes unnecessary hacks from ScriptPromise* tests.
createClosure() is abused in ScriptPromise{,Resolver}Test, and simply
removes it.
BUG=626266
==========
to
==========
Removes abuse of createClosure() from ScriptPromiseTest.
createClosure() is abused in ScriptPromise{,Resolver}Test,
so, simply removes it.
BUG=626266
==========
yukishiino@chromium.org changed reviewers: + haraken@chromium.org
Could you review this CL? I tried to remove a mysterious hack, but failed.
LGTM https://codereview.chromium.org/2144413004/diff/120001/third_party/WebKit/Sou... File third_party/WebKit/Source/bindings/core/v8/ScriptPromiseTest.cpp (right): https://codereview.chromium.org/2144413004/diff/120001/third_party/WebKit/Sou... third_party/WebKit/Source/bindings/core/v8/ScriptPromiseTest.cpp:118: v8::Function::New(scope.context(), nullptr); I'd add this to the destructor of V8TestingScope.
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by yukishiino@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by yukishiino@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from haraken@chromium.org Link to the patchset: https://codereview.chromium.org/2144413004/#ps140001 (title: "Addressed a review comment.")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
https://codereview.chromium.org/2144413004/diff/120001/third_party/WebKit/Sou... File third_party/WebKit/Source/bindings/core/v8/ScriptPromiseTest.cpp (right): https://codereview.chromium.org/2144413004/diff/120001/third_party/WebKit/Sou... third_party/WebKit/Source/bindings/core/v8/ScriptPromiseTest.cpp:118: v8::Function::New(scope.context(), nullptr); On 2016/07/21 13:28:28, haraken wrote: > > I'd add this to the destructor of V8TestingScope. Done.
Message was sent while issue was closed.
Description was changed from
==========
Removes abuse of createClosure() from ScriptPromiseTest.
createClosure() is abused in ScriptPromise{,Resolver}Test,
so, simply removes it.
BUG=626266
==========
to
==========
Removes abuse of createClosure() from ScriptPromiseTest.
createClosure() is abused in ScriptPromise{,Resolver}Test,
so, simply removes it.
BUG=626266
==========
Message was sent while issue was closed.
Committed patchset #8 (id:140001)
Message was sent while issue was closed.
Description was changed from
==========
Removes abuse of createClosure() from ScriptPromiseTest.
createClosure() is abused in ScriptPromise{,Resolver}Test,
so, simply removes it.
BUG=626266
==========
to
==========
Removes abuse of createClosure() from ScriptPromiseTest.
createClosure() is abused in ScriptPromise{,Resolver}Test,
so, simply removes it.
BUG=626266
Committed: https://crrev.com/6e8f53e38e8a711e7662626b3dd3fa5fd0106701
Cr-Commit-Position: refs/heads/master@{#407109}
==========
Message was sent while issue was closed.
Patchset 8 (id:??) landed as https://crrev.com/6e8f53e38e8a711e7662626b3dd3fa5fd0106701 Cr-Commit-Position: refs/heads/master@{#407109} |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
