Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(723)

Unified Diff: third_party/WebKit/Source/bindings/core/v8/V8BindingForTesting.cpp

Issue 2144413004: Removes abuse of createClosure() from ScriptPromiseTest. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Addressed a review comment. Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « third_party/WebKit/Source/bindings/core/v8/ScriptPromiseTest.cpp ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/bindings/core/v8/V8BindingForTesting.cpp
diff --git a/third_party/WebKit/Source/bindings/core/v8/V8BindingForTesting.cpp b/third_party/WebKit/Source/bindings/core/v8/V8BindingForTesting.cpp
index 285f8739a411c904656d95c5e73a37086c5e3b87..41a0d7940f5fe4cfcabad5f9aa748c5755346680 100644
--- a/third_party/WebKit/Source/bindings/core/v8/V8BindingForTesting.cpp
+++ b/third_party/WebKit/Source/bindings/core/v8/V8BindingForTesting.cpp
@@ -82,6 +82,11 @@ Document& V8TestingScope::document()
V8TestingScope::~V8TestingScope()
{
+ // TODO(yukishiino): We put this statement here to clear an exception from
+ // the isolate. Otherwise, the leak detector complains. Really mysterious
+ // hack.
+ v8::Function::New(context(), nullptr);
+
if (m_holder->document().frame())
getScriptState()->disposePerContextData();
}
« no previous file with comments | « third_party/WebKit/Source/bindings/core/v8/ScriptPromiseTest.cpp ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698