Removes abuse of createClosure() from ScriptPromiseTest.

third_party/WebKit/Source/bindings/core/v8/ScriptPromiseTest.cpp

 /*
  * Copyright (C) 2014 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions are
  * met:
  *
  *     * Redistributions of source code must retain the above copyright
  * notice, this list of conditions and the following disclaimer.
  *     * Redistributions in binary form must reproduce the above
@@ skipping 28 matching lines @@
 #include "core/testing/NullExecutionContext.h"
 #include "testing/gtest/include/gtest/gtest.h"
 #include <v8.h>
 
 namespace blink {
 
 namespace {
 
 typedef ScriptPromise::InternalResolver Resolver;
 
-void callback(const v8::FunctionCallbackInfo<v8::Value>& info) { }
-
 class Function : public ScriptFunction {
 public:
     static v8::Local<v8::Function> createFunction(ScriptState* scriptState, ScriptValue* output)
     {
         Function* self = new Function(scriptState, output);
         return self->bindToV8Function();
     }
 
 private:
     Function(ScriptState* scriptState, ScriptValue* output)
@@ skipping 15 matching lines @@
 class TryCatchScope {
 public:
     explicit TryCatchScope(v8::Isolate* isolate)
         : m_isolate(isolate)
         , m_trycatch(isolate)
     {
     }
 
     ~TryCatchScope()
     {
-        // FIXME: We put this statement here to clear an exception from the isolate.
-        createClosure(callback, v8::Undefined(m_isolate), m_isolate);
-
         // Execute all pending microtasks
         v8::MicrotasksScope::PerformCheckpoint(m_isolate);
     }
 
     bool hasCaught() const { return m_trycatch.HasCaught(); }
 
 private:
     v8::Isolate* m_isolate;
     v8::TryCatch m_trycatch;
 };
@@ skipping 10 matching lines @@
 }
 
 
 TEST(ScriptPromiseTest, constructFromNonPromise)
 {
     V8TestingScope scope;
     TryCatchScope tryCatchScope(scope.isolate());
     ScriptPromise promise(scope.getScriptState(), v8::Undefined(scope.isolate()));
     ASSERT_TRUE(tryCatchScope.hasCaught());
     ASSERT_TRUE(promise.isEmpty());
+
+    // TODO(yukishiino): We put this statement here to clear an exception from
+    // the isolate.  Otherwise, the leak detector complains.  Really mysterious
+    // hack.
+    v8::Function::New(scope.context(), nullptr);

[haraken, 2016/07/21 13:28:28]

I'd add this to the destructor of V8TestingScope.

[Yuki, 2016/07/22 09:10:31]

Done.

 }
 
 TEST(ScriptPromiseTest, thenResolve)
 {
     V8TestingScope scope;
     TryCatchScope tryCatchScope(scope.isolate());
     Resolver resolver(scope.getScriptState());
     ScriptPromise promise = resolver.promise();
     ScriptValue onFulfilled, onRejected;
     promise.then(Function::createFunction(scope.getScriptState(), &onFulfilled), Function::createFunction(scope.getScriptState(), &onRejected));
@@ skipping 230 matching lines @@
     v8::MicrotasksScope::PerformCheckpoint(scope.isolate());
 
     EXPECT_TRUE(onFulfilled.isEmpty());
     EXPECT_FALSE(onRejected.isEmpty());
     EXPECT_EQ("world", toString(scope.context(), onRejected));
 }
 
 } // namespace
 
 } // namespace blink