third_party/WebKit/Source/bindings/core/v8/ScriptPromiseTest.cpp - Issue 2144413004: Removes abuse of createClosure() from ScriptPromiseTest.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/bindings/core/v8/ScriptPromiseTest.cpp

Issue 2144413004: Removes abuse of createClosure() from ScriptPromiseTest. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Addressed a review comment. Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/bindings/core/v8/ScriptPromiseResolverTest.cpp ('k') | third_party/WebKit/Source/bindings/core/v8/V8BindingForTesting.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/bindings/core/v8/ScriptPromiseTest.cpp

diff --git a/third_party/WebKit/Source/bindings/core/v8/ScriptPromiseTest.cpp b/third_party/WebKit/Source/bindings/core/v8/ScriptPromiseTest.cpp

index 7146ae52bb7f5875f4343a7e35da23b3a4499a0c..21e908eb88a924652607521598edfef6fbc6fb3b 100644

--- a/third_party/WebKit/Source/bindings/core/v8/ScriptPromiseTest.cpp

+++ b/third_party/WebKit/Source/bindings/core/v8/ScriptPromiseTest.cpp

@@ -46,8 +46,6 @@ namespace {

typedef ScriptPromise::InternalResolver Resolver;

-void callback(const v8::FunctionCallbackInfo<v8::Value>& info) { }

class Function : public ScriptFunction {

public:

static v8::Local<v8::Function> createFunction(ScriptState* scriptState, ScriptValue* output)

@@ -83,9 +81,6 @@ public:

~TryCatchScope()

{

- // FIXME: We put this statement here to clear an exception from the isolate.

- createClosure(callback, v8::Undefined(m_isolate), m_isolate);

// Execute all pending microtasks

v8::MicrotasksScope::PerformCheckpoint(m_isolate);

}