Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1860)

Unified Diff: third_party/WebKit/Source/core/html/HTMLSelectElement.h

Issue 2143863003: Simplify protocol between SELECT elements and popups. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@select-remove-fixed-args
Patch Set: Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/html/HTMLSelectElement.h
diff --git a/third_party/WebKit/Source/core/html/HTMLSelectElement.h b/third_party/WebKit/Source/core/html/HTMLSelectElement.h
index ae02da44d2e4bd15cd3d5af4f484dbf1b7055fbd..28e23224d42764b79c716a9b300d9815c61383eb 100644
--- a/third_party/WebKit/Source/core/html/HTMLSelectElement.h
+++ b/third_party/WebKit/Source/core/html/HTMLSelectElement.h
@@ -149,10 +149,8 @@ public:
LayoutUnit clientPaddingLeft() const;
// Text starting offset in RTL.
LayoutUnit clientPaddingRight() const;
- void valueChanged(unsigned listIndex);
- // TODO(tkent): Rename this. This is used only for multiple-selection
- // menulist.
- void listBoxSelectItem(int listIndex, bool allowMultiplySelections, bool fireOnChangeNow);
+ void selectOptionByPopup(int listIndex);
+ void selectMultipleOptionsByPopup(const Vector<int>& listIndices);
// A popup is canceled when the popup was hidden without selecting an item.
void popupDidCancel();
// Provisional selection is a selection made using arrow keys or type ahead.

Powered by Google App Engine
This is Rietveld 408576698