third_party/WebKit/Source/web/PopupMenuImpl.cpp - Issue 2143863003: Simplify protocol between SELECT elements and popups.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/web/PopupMenuImpl.cpp

Issue 2143863003: Simplify protocol between SELECT elements and popups. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@select-remove-fixed-args

Patch Set: Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: third_party/WebKit/Source/web/PopupMenuImpl.cpp

diff --git a/third_party/WebKit/Source/web/PopupMenuImpl.cpp b/third_party/WebKit/Source/web/PopupMenuImpl.cpp

index d40ba44209e91370c4296db20b4ae613b1beb6b3..f58126223d22fcb81a32dedf076e71f3a7da6869 100644

--- a/third_party/WebKit/Source/web/PopupMenuImpl.cpp

+++ b/third_party/WebKit/Source/web/PopupMenuImpl.cpp

@@ -398,7 +398,7 @@ void PopupMenuImpl::setValueAndClosePopup(int numValue, const String& stringValu

DCHECK(success);

{

EventQueueScope scope;

- m_ownerElement->valueChanged(listIndex);

+ m_ownerElement->selectOptionByPopup(listIndex);

if (m_popup)

m_chromeClient->closePagePopup(m_popup);

// 'change' event is dispatched here. For compatbility with

« third_party/WebKit/Source/core/html/HTMLSelectElement.cpp ('K') | « third_party/WebKit/Source/web/ExternalPopupMenu.cpp ('k') | no next file » | no next file with comments »