Remove LocalFrameLifecycleObserver::willDetachFrameHost()

Remove LocalFrameLifecycleObserver::willDetachFrameHost()

willDetachFrameHost() is dispatched at almost the same timing as contextDestroyed().
Hence this CL replaces willDetachFrameHost() with contextDestroyed().

The only exception is LocalDOMWindow::willDetachFrameHost().
It needs to be called before the frame is actually detached from the frame host,
so this CL moves the contents to LocalFrame::detach().

BUG=610176
Committed: https://crrev.com/d1d739c3a4cd78b3a4aa5a8a6ebf313df2dca1e3
Cr-Commit-Position: refs/heads/master@{#404924}

[haraken, 2016-07-12 02:39:20]

haraken@chromium.org changed reviewers:
+ dcheng@chromium.org

[haraken, 2016-07-12 02:39:21]

PTAL

I was thinking that willDetachFrameHost() is not called at every Frame::detach,
but it looks like it's called. Anyway, we can replace it with
contextDestroyed().

[dcheng, 2016-07-12 03:11:24]

LGTM

[haraken, 2016-07-12 03:44:00]

The CQ bit was checked by haraken@chromium.org

[commit-bot: I haz the power, 2016-07-12 03:45:05]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-12 04:07:57]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-12 04:07:58]

Try jobs failed on following builders:
  cast_shell_linux on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linu...)

[haraken, 2016-07-12 04:08:32]

The CQ bit was checked by haraken@chromium.org

[commit-bot: I haz the power, 2016-07-12 04:09:23]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-12 04:41:36]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-12 04:41:37]

Try jobs failed on following builders:
  linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[haraken, 2016-07-12 06:28:32]

The CQ bit was checked by haraken@chromium.org

[haraken, 2016-07-12 06:28:33]

The patchset sent to the CQ was uploaded after l-g-t-m from dcheng@chromium.org
Link to the patchset: https://codereview.chromium.org/2142753002/#ps20001
(title: "temp")

[commit-bot: I haz the power, 2016-07-12 06:29:34]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-12 07:00:23]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-12 07:00:24]

Try jobs failed on following builders:
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)

[haraken, 2016-07-12 07:49:07]

The CQ bit was checked by haraken@chromium.org

[commit-bot: I haz the power, 2016-07-12 07:49:27]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-12 08:08:32]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-12 08:08:36]

Try jobs failed on following builders:
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[haraken, 2016-07-12 09:23:08]

The CQ bit was checked by haraken@chromium.org

[commit-bot: I haz the power, 2016-07-12 09:23:36]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-12 11:52:08]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-12 11:52:10]

Try jobs failed on following builders:
  linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[haraken, 2016-07-13 00:04:25]

The CQ bit was checked by haraken@chromium.org

[commit-bot: I haz the power, 2016-07-13 00:07:36]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-13 02:43:46]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-07-13 02:44:13]

CQ bit was unchecked.

[commit-bot: I haz the power, 2016-07-13 02:45:44]

Description was changed from

==========
Remove LocalFrameLifecycleObserver::willDetachFrameHost()

willDetachFrameHost() is dispatched at almost the same timing as
contextDestroyed().
Hence this CL replaces willDetachFrameHost() with contextDestroyed().

The only exception is LocalDOMWindow::willDetachFrameHost().
It needs to be called before the frame is actually detached from the frame host,
so this CL moves the contents to LocalFrame::detach().

BUG=610176
==========

to

==========
Remove LocalFrameLifecycleObserver::willDetachFrameHost()

willDetachFrameHost() is dispatched at almost the same timing as
contextDestroyed().
Hence this CL replaces willDetachFrameHost() with contextDestroyed().

The only exception is LocalDOMWindow::willDetachFrameHost().
It needs to be called before the frame is actually detached from the frame host,
so this CL moves the contents to LocalFrame::detach().

BUG=610176

Committed: https://crrev.com/d1d739c3a4cd78b3a4aa5a8a6ebf313df2dca1e3
Cr-Commit-Position: refs/heads/master@{#404924}
==========

[commit-bot: I haz the power, 2016-07-13 02:45:48]

Patchset 2 (id:??) landed as
https://crrev.com/d1d739c3a4cd78b3a4aa5a8a6ebf313df2dca1e3
Cr-Commit-Position: refs/heads/master@{#404924}