Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(31)

Unified Diff: third_party/WebKit/Source/modules/vr/VRController.h

Issue 2142753002: Remove LocalFrameLifecycleObserver::willDetachFrameHost() (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: temp Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/modules/vr/VRController.h
diff --git a/third_party/WebKit/Source/modules/vr/VRController.h b/third_party/WebKit/Source/modules/vr/VRController.h
index 32c984cd77937391708ab07aec2322d5969abf4b..3e01a2fc715e5f48db600b1766a1c9725eb23e24 100644
--- a/third_party/WebKit/Source/modules/vr/VRController.h
+++ b/third_party/WebKit/Source/modules/vr/VRController.h
@@ -5,7 +5,7 @@
#ifndef VRController_h
#define VRController_h
-#include "core/frame/LocalFrameLifecycleObserver.h"
+#include "core/frame/LocalFrame.h"
#include "device/vr/vr_service.mojom-blink.h"
#include "modules/ModulesExport.h"
#include "platform/Supplementable.h"
@@ -20,8 +20,7 @@ class VRGetDevicesCallback;
class MODULES_EXPORT VRController final
: public GarbageCollectedFinalized<VRController>
- , public Supplement<LocalFrame>
- , public LocalFrameLifecycleObserver {
+ , public Supplement<LocalFrame> {
USING_GARBAGE_COLLECTED_MIXIN(VRController);
WTF_MAKE_NONCOPYABLE(VRController);
public:
@@ -42,9 +41,6 @@ public:
private:
VRController(LocalFrame&, ServiceRegistry*);
- // Inherited from LocalFrameLifecycleObserver.
- void willDetachFrameHost() override;
-
// Binding callbacks.
void onGetDisplays(mojo::WTFArray<device::blink::VRDisplayPtr>);

Powered by Google App Engine
This is Rietveld 408576698