third_party/WebKit/Source/core/frame/LocalFrameLifecycleObserver.h - Issue 2142753002: Remove LocalFrameLifecycleObserver::willDetachFrameHost()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/frame/LocalFrameLifecycleObserver.h

Issue 2142753002: Remove LocalFrameLifecycleObserver::willDetachFrameHost() (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: temp Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/frame/LocalFrameLifecycleNotifier.cpp ('k') | third_party/WebKit/Source/modules/installedapp/InstalledAppController.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/frame/LocalFrameLifecycleObserver.h

diff --git a/third_party/WebKit/Source/core/frame/LocalFrameLifecycleObserver.h b/third_party/WebKit/Source/core/frame/LocalFrameLifecycleObserver.h

index 7fa60acf5873d39fe7df38f6b64efc6bf702cbe4..7dbe92d1f1a0fad9ea6253ba54f38d5e2ac7bb6f 100644

--- a/third_party/WebKit/Source/core/frame/LocalFrameLifecycleObserver.h

+++ b/third_party/WebKit/Source/core/frame/LocalFrameLifecycleObserver.h

@@ -37,7 +37,6 @@ class LocalFrame;

class CORE_EXPORT LocalFrameLifecycleObserver : public LifecycleObserver<LocalFrame, LocalFrameLifecycleObserver> {

public:

- virtual void willDetachFrameHost() { }

virtual void contextDestroyed()

{

setContext(nullptr);