Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1094)

Unified Diff: third_party/WebKit/Source/modules/vr/VRController.cpp

Issue 2142753002: Remove LocalFrameLifecycleObserver::willDetachFrameHost() (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: temp Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « third_party/WebKit/Source/modules/vr/VRController.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/modules/vr/VRController.cpp
diff --git a/third_party/WebKit/Source/modules/vr/VRController.cpp b/third_party/WebKit/Source/modules/vr/VRController.cpp
index 88a21280c616e210521cf2d1009594015421aa98..455d7006905e9c9198af59a550dd4713c2a13cfe 100644
--- a/third_party/WebKit/Source/modules/vr/VRController.cpp
+++ b/third_party/WebKit/Source/modules/vr/VRController.cpp
@@ -28,7 +28,6 @@ VRController* VRController::from(LocalFrame& frame)
}
VRController::VRController(LocalFrame& frame, ServiceRegistry* registry)
- : LocalFrameLifecycleObserver(&frame)
{
ASSERT(!m_service.is_bound());
registry->connectToRemoteService(mojo::GetProxy(&m_service));
@@ -67,11 +66,6 @@ void VRController::resetPose(unsigned index)
m_service->ResetPose(index);
}
-void VRController::willDetachFrameHost()
-{
- // TODO(kphanee): Detach from the mojo service connection.
-}
-
void VRController::onGetDisplays(mojo::WTFArray<device::blink::VRDisplayPtr> displays)
{
std::unique_ptr<VRGetDevicesCallback> callback = m_pendingGetDevicesCallbacks.takeFirst();
@@ -84,7 +78,6 @@ void VRController::onGetDisplays(mojo::WTFArray<device::blink::VRDisplayPtr> dis
DEFINE_TRACE(VRController)
{
Supplement<LocalFrame>::trace(visitor);
- LocalFrameLifecycleObserver::trace(visitor);
}
} // namespace blink
« no previous file with comments | « third_party/WebKit/Source/modules/vr/VRController.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698