Issue 2142473002: Update strings in the credit card unmask dialog.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2142473002: Update strings in the credit card unmask dialog. (Closed)

Created:
4 years, 5 months ago by Justin Donnelly

Modified:
4 years, 5 months ago

Reviewers:

CC:
chromium-reviews

Base URL:
https://chromium.googlesource.com/chromium/src.git@2785

Target Ref:
refs/pending/branch-heads/2785

Project:
chromium

Visibility:
Public.

Update strings in the credit card unmask dialog. The new design doesn't treat Amex cards or the PaymentRequest case differently, so the code is simplified a bit as well. BUG=626237 Review-Url: https://codereview.chromium.org/2127293002 Cr-Commit-Position: refs/heads/master@{#404392} (cherry picked from commit 47f009f01f84d5e419c2c23588f62da47b1ad2eb) Committed: https://chromium.googlesource.com/chromium/src/+/0bf2fcf622696ad18ae16624a74bea078123879c

Created: 4 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+25 lines, -67 lines)			Patch
	M	components/autofill/core/browser/ui/card_unmask_prompt_controller_impl.cc	View		1 chunk	+13 lines, -22 lines	0 comments	Download
	M	components/autofill_strings.grdp	View		2 chunks	+12 lines, -45 lines	0 comments	Download

Total messages: 2 (1 generated)

Justin Donnelly

4 years, 5 months ago (2016-07-11 15:24:15 UTC) #2

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
0bf2fcf622696ad18ae16624a74bea078123879c.