Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(637)

Issue 2127293002: Update strings in the credit card unmask dialog. (Closed)

Created:
4 years, 5 months ago by Justin Donnelly
Modified:
4 years, 5 months ago
Reviewers:
Mathieu
CC:
chromium-reviews, rouslan+autofill_chromium.org, estade+watch_chromium.org, vabr+watchlistautofill_chromium.org, browser-components-watch_chromium.org, jdonnelly+autofillwatch_chromium.org, please use gerrit instead
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Update strings in the credit card unmask dialog. The new design doesn't treat Amex cards or the PaymentRequest case differently, so the code is simplified a bit as well. BUG=626237 Committed: https://crrev.com/47f009f01f84d5e419c2c23588f62da47b1ad2eb Cr-Commit-Position: refs/heads/master@{#404392}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+25 lines, -67 lines) Patch
M components/autofill/core/browser/ui/card_unmask_prompt_controller_impl.cc View 1 chunk +13 lines, -22 lines 0 comments Download
M components/autofill_strings.grdp View 2 chunks +12 lines, -45 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
Justin Donnelly
4 years, 5 months ago (2016-07-08 00:07:22 UTC) #2
Mathieu
lgtm
4 years, 5 months ago (2016-07-08 04:26:24 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2127293002/1
4 years, 5 months ago (2016-07-08 15:28:30 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-07-08 15:33:01 UTC) #6
commit-bot: I haz the power
CQ bit was unchecked.
4 years, 5 months ago (2016-07-08 15:33:09 UTC) #7
commit-bot: I haz the power
4 years, 5 months ago (2016-07-08 15:33:59 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/47f009f01f84d5e419c2c23588f62da47b1ad2eb
Cr-Commit-Position: refs/heads/master@{#404392}

Powered by Google App Engine
This is Rietveld 408576698