[Extensions] Clean up renderer channel-related code

[Extensions] Clean up renderer channel-related code

version_info::Channel is a component, so we can include it in
//extensions and clean up a bunch of messy back-and-forth with //chrome.

BUG=626774
TBR=jam@chromium.org (chrome_content_client include path change)

Committed: https://crrev.com/ea63fff365730c62da696327aef771d74d01c78a
Cr-Commit-Position: refs/heads/master@{#406003}

[Devlin, 2016-07-11 21:59:57]

Patchset #1 (id:1) has been deleted

[Devlin, 2016-07-11 22:01:04]

rdevlin.cronin@chromium.org changed reviewers:
+ lazyboy@chromium.org

[Devlin, 2016-07-11 22:01:04]

Follows https://codereview.chromium.org/2137463003.  (Red bots because it looks
like rietveld is having some difficulty patching with all the file removals)

[lazyboy, 2016-07-11 23:53:16]

lgtm

https://codereview.chromium.org/2141703003/diff/20001/extensions/common/featu...
File extensions/common/features/feature_util.h (right):

https://codereview.chromium.org/2141703003/diff/20001/extensions/common/featu...
extensions/common/features/feature_util.h:37: bool
ExtensionServiceWorkersEnabled();
I can't find where this is defined anymore, some patch hiccup?

[Devlin, 2016-07-13 22:26:06]

Patchset #4 (id:80001) has been deleted

[Devlin, 2016-07-13 22:26:11]

Patchset #3 (id:60001) has been deleted

[Devlin, 2016-07-13 22:26:24]

The CQ bit was checked by rdevlin.cronin@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-07-13 22:27:04]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-13 23:06:23]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-13 23:06:24]

Dry run: Try jobs failed on following builders:
  linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Devlin, 2016-07-13 23:23:15]

The CQ bit was checked by rdevlin.cronin@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-07-13 23:24:07]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-13 23:39:48]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-13 23:39:49]

Dry run: Try jobs failed on following builders:
  linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_chromeos_compile_dbg_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Devlin, 2016-07-14 16:40:05]

The CQ bit was checked by rdevlin.cronin@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-07-14 16:40:16]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-14 17:23:48]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-14 17:23:49]

Dry run: This issue passed the CQ dry run.

[Devlin, 2016-07-14 17:30:09]

Patchset #4 (id:120001) has been deleted

[Devlin, 2016-07-14 17:32:11]

https://codereview.chromium.org/2141703003/diff/20001/extensions/common/featu...
File extensions/common/features/feature_util.h (right):

https://codereview.chromium.org/2141703003/diff/20001/extensions/common/featu...
extensions/common/features/feature_util.h:37: bool
ExtensionServiceWorkersEnabled();
On 2016/07/11 23:53:16, lazyboy wrote:
> I can't find where this is defined anymore, some patch hiccup?

Whoops, missed the file originally.  Added.

https://codereview.chromium.org/2141703003/diff/140001/chrome/common/extensio...
File chrome/common/extensions/chrome_extensions_client.cc (left):

https://codereview.chromium.org/2141703003/diff/140001/chrome/common/extensio...
chrome/common/extensions/chrome_extensions_client.cc:69:
feature->set_check_channel(true);
Woohoo, we can indeed remove this.

[Devlin, 2016-07-14 17:32:17]

The CQ bit was checked by rdevlin.cronin@chromium.org

[Devlin, 2016-07-14 17:32:18]

The patchset sent to the CQ was uploaded after l-g-t-m from lazyboy@chromium.org
Link to the patchset: https://codereview.chromium.org/2141703003/#ps140001
(title: "Test fix")

[commit-bot: I haz the power, 2016-07-14 17:32:41]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-14 17:42:28]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-14 17:42:29]

Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[Devlin, 2016-07-14 17:51:10]

rdevlin.cronin@chromium.org changed reviewers:
+ dcheng@chromium.org

[Devlin, 2016-07-14 17:51:11]

+dcheng for extension_messages.h

[Devlin, 2016-07-15 22:49:15]

On 2016/07/14 17:51:11, Devlin wrote:
> +dcheng for extension_messages.h

friendly ping -> dcheng :)

[dcheng, 2016-07-18 05:02:24]

rs lgtm for ipc changes

[Devlin, 2016-07-18 14:10:16]

The CQ bit was checked by rdevlin.cronin@chromium.org

[commit-bot: I haz the power, 2016-07-18 14:10:35]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-18 14:16:44]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-18 14:16:45]

Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[Devlin, 2016-07-18 15:05:48]

Description was changed from

==========
[Extensions] Clean up renderer channel-related code

version_info::Channel is a component, so we can include it in
//extensions and clean up a bunch of messy back-and-forth with //chrome.

BUG=
==========

to

==========
[Extensions] Clean up renderer channel-related code

version_info::Channel is a component, so we can include it in
//extensions and clean up a bunch of messy back-and-forth with //chrome.

BUG=626774
TBR=jam@chromium.org (chrome_content_client include path change)
==========

[Devlin, 2016-07-18 15:05:48]

rdevlin.cronin@chromium.org changed reviewers:
+ jam@chromium.org

[Devlin, 2016-07-18 15:05:58]

The CQ bit was checked by rdevlin.cronin@chromium.org

[commit-bot: I haz the power, 2016-07-18 15:06:51]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-18 15:49:52]

Description was changed from

==========
[Extensions] Clean up renderer channel-related code

version_info::Channel is a component, so we can include it in
//extensions and clean up a bunch of messy back-and-forth with //chrome.

BUG=626774
TBR=jam@chromium.org (chrome_content_client include path change)
==========

to

==========
[Extensions] Clean up renderer channel-related code

version_info::Channel is a component, so we can include it in
//extensions and clean up a bunch of messy back-and-forth with //chrome.

BUG=626774
TBR=jam@chromium.org (chrome_content_client include path change)
==========

[commit-bot: I haz the power, 2016-07-18 15:49:53]

Committed patchset #4 (id:140001)

[commit-bot: I haz the power, 2016-07-18 15:49:57]

CQ bit was unchecked.

[commit-bot: I haz the power, 2016-07-18 15:52:46]

Description was changed from

==========
[Extensions] Clean up renderer channel-related code

version_info::Channel is a component, so we can include it in
//extensions and clean up a bunch of messy back-and-forth with //chrome.

BUG=626774
TBR=jam@chromium.org (chrome_content_client include path change)
==========

to

==========
[Extensions] Clean up renderer channel-related code

version_info::Channel is a component, so we can include it in
//extensions and clean up a bunch of messy back-and-forth with //chrome.

BUG=626774
TBR=jam@chromium.org (chrome_content_client include path change)

Committed: https://crrev.com/ea63fff365730c62da696327aef771d74d01c78a
Cr-Commit-Position: refs/heads/master@{#406003}
==========

[commit-bot: I haz the power, 2016-07-18 15:52:47]

Patchset 4 (id:??) landed as
https://crrev.com/ea63fff365730c62da696327aef771d74d01c78a
Cr-Commit-Position: refs/heads/master@{#406003}