extensions/common/extension_messages.h - Issue 2141703003: [Extensions] Clean up renderer channel-related code

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: extensions/common/extension_messages.h

Issue 2141703003: [Extensions] Clean up renderer channel-related code (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@dc_feature_no_filter

Patch Set: Test fix Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/common/extensions/chrome_extensions_client.cc ('K') | « extensions/browser/renderer_startup_helper.cc ('k') | extensions/common/features/feature_util.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: extensions/common/extension_messages.h

diff --git a/extensions/common/extension_messages.h b/extensions/common/extension_messages.h

index 6e94d79f46faa1e195e6dfe9f2a1f7282723b2e6..320bda7ac3622a32fcd3a76fae908b12b0f5ba33 100644

--- a/extensions/common/extension_messages.h

+++ b/extensions/common/extension_messages.h

@@ -12,6 +12,7 @@

#include "base/memory/shared_memory.h"

#include "base/values.h"

+#include "components/version_info/version_info.h"

#include "content/public/common/common_param_traits.h"

#include "content/public/common/socket_permission_request.h"

#include "extensions/common/api/messaging/message.h"

@@ -44,6 +45,7 @@ IPC_ENUM_TRAITS_MAX_VALUE(extensions::UserScript::RunLocation,

extensions::UserScript::RUN_LOCATION_LAST - 1)

IPC_ENUM_TRAITS_MAX_VALUE(HostID::HostType, HostID::HOST_TYPE_LAST)

+IPC_ENUM_TRAITS_MAX_VALUE(version_info::Channel, version_info::Channel::STABLE)

// Parameters structure for ExtensionHostMsg_AddAPIActionToActivityLog and

// ExtensionHostMsg_AddEventToActivityLog.

@@ -590,7 +592,7 @@ IPC_MESSAGE_ROUTED2(ExtensionMsg_DispatchOnDisconnect,

// Informs the renderer what channel (dev, beta, stable, etc) is running.

IPC_MESSAGE_CONTROL1(ExtensionMsg_SetChannel,

- int /* channel */)

+ version_info::Channel /* channel */)

// Notify the renderer that its window has closed.

IPC_MESSAGE_ROUTED0(ExtensionMsg_AppWindowClosed)