chrome/common/extensions/chrome_extensions_client.cc - Issue 2141703003: [Extensions] Clean up renderer channel-related code

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/common/extensions/chrome_extensions_client.cc

Issue 2141703003: [Extensions] Clean up renderer channel-related code (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@dc_feature_no_filter

Patch Set: Test fix Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/common/extensions/chrome_extensions_client.cc

diff --git a/chrome/common/extensions/chrome_extensions_client.cc b/chrome/common/extensions/chrome_extensions_client.cc

index a261245bbced8116d515dcc9facd9335866ab3dd..4f85c1f07250bd4d0dd5e44076bb9c3440eb60a8 100644

--- a/chrome/common/extensions/chrome_extensions_client.cc

+++ b/chrome/common/extensions/chrome_extensions_client.cc

@@ -65,9 +65,7 @@ const char kThumbsWhiteListedExtension[] = "khopmbdjffemhegeeobelklnbglcdgfh";

template <class FeatureClass>

SimpleFeature* CreateFeature() {

- SimpleFeature* feature = new FeatureClass();

- feature->set_check_channel(true);

Devlin 2016/07/14 17:32:11 Woohoo, we can indeed remove this.

- return feature;

+ return new FeatureClass();

}

// Mirrors version_info::Channel for histograms.

« no previous file with comments | « chrome/common/chrome_content_client.cc ('k') | chrome/common/extensions/features/feature_util.h » ('j') | no next file with comments »